Skip to content

Task pointer should be nulled #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zmechanic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Task pointer should be nulled #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions websocket_server.c
View file
Open in desktop
Copy link

@Paulo-Pecegueiro Paulo-Pecegueiro Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itay-grudev @klaus-liebler @efuturetoday @Molorius Could you merge this branch? @zmechanic is absolutely correct, as the task handler is being used as a validator to create the task, it must be set to null after deleting the task, as Freertos does not do this itself and otherwise the task will never be started again after have been deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ int ws_server_start() {
int ws_server_stop() {
if(!xtask) return 0;
vTaskDelete(xtask);
xtask = NULL;
return 1;
}

Expand Down