Refactoring message type

MoniqueNijboer · Jun 29, 2015 · d3aa199 · d3aa199
1 parent 8150deb
commit d3aa199
Showing 1 changed file with 19 additions and 11 deletions.
diff --git a/src/Types/Message.php b/src/Types/Message.php
@@ -570,26 +570,34 @@ public static function fromResponse($data)
         }
 
         if (isset($data['new_chat_photo'])) {
-            $newChatPhoto = array();
-            foreach ($data['new_chat_photo'] as $newChatPhotoItem) {
-                $newChatPhoto[] = PhotoSize::fromResponse($newChatPhotoItem);
-            }
-            $instance->setNewChatPhoto($newChatPhoto);
+            $instance->setNewChatPhoto(self::generateArrayOfPhotoSize($data['new_chat_photo']));
         }
 
         if (isset($data['photo'])) {
-            $photo = array();
-            foreach ($data['photo'] as $photoItem) {
-                $photo[] = PhotoSize::fromResponse($photoItem);
-            }
-            $instance->setPhoto($photo);
+            $instance->setPhoto(self::generateArrayOfPhotoSize($data['photo']));
         }
 
-
         if (isset($data['group_chat_created'])) {
             $instance->setGroupChatCreated($data['group_chat_created']);
         }
 
         return $instance;
     }
+
+    /**
+     * Returns array of PhotoSize from raw
+     *
+     * @param $data
+     *
+     * @return array
+     */
+    protected static function generateArrayOfPhotoSize($data)
+    {
+        $arrayOfPhotoSize = array();
+        foreach ($data as $photoSizeItem) {
+            $arrayOfPhotoSize[] = PhotoSize::fromResponse($photoSizeItem);
+        }
+
+        return $arrayOfPhotoSize;
+    }
 }