Skip to content

Hand Subclass: The Huntsmaster#6486

Draft
Spitegremlin wants to merge 6 commits into
Monkestation:mainfrom
Spitegremlin:Handsubclassanddog
Draft

Hand Subclass: The Huntsmaster#6486
Spitegremlin wants to merge 6 commits into
Monkestation:mainfrom
Spitegremlin:Handsubclassanddog

Conversation

@Spitegremlin
Copy link
Copy Markdown

@Spitegremlin Spitegremlin commented May 16, 2026

About The Pull Request

Adds a new subclass for hand, called the Huntsmaster, has a hound and is bow focused, along with a new hound, and a new Gambeson

Why It's Good For The Game

Adds more choices for what you can do

Changelog

🆑
add: Added Huntsmaster Hand subclass, along with their hound
add: Added new Gambeson. Hunting Gambeson
add: Added new trait called keen eyes, and gave it to hunters and huntsmaster
add: Added a trait called flip jump to Spymaster, doesnt do anything other then let them flip when they jump
balance: gave Advisor a glock
balance: gave all hand subclasses a standard 8 since i was told too, and the default hand class had 8
balance: gave pilgrim hunter forager and keeneyes trait, to match with normal hunter
image: added/modified/removed some icons or images
code: changed some code
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@github-actions github-actions Bot added the Code Maintenance Fixing this mess one line at a time label May 16, 2026
@Spitegremlin Spitegremlin marked this pull request as draft May 16, 2026 19:11
@Spitegremlin
Copy link
Copy Markdown
Author

Spitegremlin commented May 16, 2026

NOT done yet, this is just to finish hand stuff, im going to add some advisor things (gun in a hollow book...) and make the Gambeson i made craftable

@Spitegremlin Spitegremlin marked this pull request as ready for review May 18, 2026 10:57
Comment thread code/modules/clothing/armor/gambesson.dm
Comment on lines +59 to +63
traits = list(
TRAIT_KEENEYES,
TRAIT_FORAGER
)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Also undocumented in changelog.

Copy link
Copy Markdown
Author

@Spitegremlin Spitegremlin May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quirk was literally made for hunters yet its a costly quirk for a relatively minor effect so its not worth taking over other quirks, and says its for people that hunt in the flavor text, yet they dont get it, since I made it a trait and gave it to Huntsmaster i decided that normal hunter should get the hunter trait as well

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, normal hunter gets FORAGER, yet pilgrim didnt, so i fixed that

TRAIT_MEDIUMARMOR,
TRAIT_DODGEEXPERT
TRAIT_DODGEEXPERT,
TRAIT_FLIP_JUMP
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Also undocumented in changelog.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was because of what a admin asked me to do, kinda forgot about it, but it only lets them flip jump

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked them to include flip jump for flavor.

raw_attribute_list = list(
STAT_INTELLIGENCE = 5,
STAT_PERCEPTION = 4,
STAT_PERCEPTION = 5,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Also undocumented in changelog.

Copy link
Copy Markdown
Author

@Spitegremlin Spitegremlin May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was told to bring all the hand stats to 8, since the default hand gets 8 yet the others didnt get 8

raw_attribute_list = list(
STAT_INTELLIGENCE = 4,
STAT_PERCEPTION = 3,
STAT_PERCEPTION = 4,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, forgot about it, just bringing everything to a baseline of 8

attribute_sheet_old = /datum/attribute_holder/sheet/job/hunter/old

traits = list(
TRAIT_KEENEYES,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Also undocumented in changelog.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving hunter keeneyes because it was made for hunters

Comment on lines +2532 to +2533
if(HAS_TRAIT(src, TRAIT_KEENEYES))
looktime *= 0.25
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making a quirk have a trait verison

@realforest2001 realforest2001 marked this pull request as draft May 18, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Maintenance Fixing this mess one line at a time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants