[pull] master from mstilkerich:master#94
Open
pull[bot] wants to merge 142 commits intoMonogramm:masterfrom
Open
[pull] master from mstilkerich:master#94pull[bot] wants to merge 142 commits intoMonogramm:masterfrom
pull[bot] wants to merge 142 commits intoMonogramm:masterfrom
Conversation
There is still a couple of issues (reported to psalm) and thus quite a few workaround annotations that can hopefully be removed in the future.
The change to the previous behavior is that no error messages will be logged anymore in case read-only or inactive addressbooks pass the matchurl/matchname filters and are subsequently sorted out. This change means the admin will not have no make sure the matchers do not match read-only (and inactive) addressbooks, as these will not even be considered in the initial set of candidates.
This avoids error messages in case the name attribute is fixed and the name template refers to server-side properties of an addressbook, which could not be queried anymore
…s of an addressbook gracefully When a fixed name setting is used and the template refers to server-side properties of an addressbook, this querying may fail and would have caused the updating of the preset to be aborted with an error logged. Now this is handled better in that only the name attribute will not be updated on failure to get the current server side property values, but the other fixed attributes and the other addressbooks of the server will still be updated.
This would happen when the shortcut in AdminSettings::getAddressbookTemplate() was taken to simply return the complete preset as template addressbook. However, this would have caused the addressbook template to override account fields when creating the UI form. While the latter is fixed in this commit as well, it is not expected to have account attributes inside the template addressbook in the first place, so this is addressed now, too.
This could only happen with manipulated requests. However, when the admin configures a preset account as hidden, their intention is that the user cannot see or modify the preferences for this account, so it makes sense to ensure this.
…e form itself An ID must only be assigned to one DOM element. We do not need IDs on the tables, so simply remove them at that place.
Omit the value attribute instead
Psalm will make sure we do not call these functions with unknown UI element types.
Newer versions of mysql docker image do not include the which command
It does not contain the mysql commands anymore
Psalm 5.26 is not compatible with PHP 8.4, therefore the unittest target with PHP 8.4 does not work (composer cannot resolve dependencies). But we need psalm only for the staticanalyses target.
Did not migrate the config file yet; migrating to PHPUnit would mean we cannot run unit tests for PHP versions below 8.1 anymore. Not sure about this yet.
PHPUnit 10 does not create the directory itself anymore
Roundcube 1.7 has removed support for all databases rcmcarddav did not support, so this test can no longer be run on RC 1.7.
git clone done by composer does not work anymore in Parallels shared folder as of Parallels 26 as hard link appear not handled properly. Build in a local directory.
These cause problems when we want to compare dumps, so we run sed to make sure they use the same key. We cannot use the --restrict-key option to pg_dump to achieve this as it is not available in pre-version 13 postgres which we still run on the CI system.
Added a section about the necessary settings required in Nextcloud to get the Bearer token authentication to work.
- They cannot have a default initialization, they may only be initialized once. - The psalm-allow-private-mutation annotation conflicts with this idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )