fix(kap-server): verify indexed search results against session sources by wbxl2000 · Pull Request #3631 · MoonshotAI/kimi-code

wbxl2000 · 2026-09-07T17:57:08Z

Related Issue

Related to #3543 and #3630. Replaces the search-index deletion machinery from #3544. #3630 has merged; this branch includes the current deletion API baseline.

Problem

A deleted session can remain in a writer's unsynchronized index or another process's stale read-only view. Scheduling another sync does not give a time bound, and a deletion ledger creates a second persistence protocol whose compaction, reader lag, and ID reuse must all be coordinated.

What changed

Bind indexed messages and titles to their source session directory's filesystem identity (device, inode, and birth time). Validate each distinct source while querying and filter missing or replaced sources before pagination, including read-only workers. Filesystems without a positive inode and birth time cannot provide this verification, so their indexed results remain hidden until the source can be verified and reindexed. Query source checks share a single outstanding filesystem operation per worker. A timed-out request retains that permit until its stat settles; waiting queries expire without issuing more filesystem work or retaining waiters. Later queries perform fresh checks rather than reuse old results. Source checks share the query deadline; a stalled source returns only already-verified results with incomplete: deadline.
Sessions skipped during indexing are excluded from the indexed count and reported in persisted degraded status, including read-only readers; recovery clears the status.
Read titles from the source session metadata and keep them with that identity. A stale session-list snapshot cannot attach an old title to a recreated session. Normal renames update displayed titles without rewriting unchanged message documents; damaged optional title metadata does not stop message indexing.
Reuse the existing writer sync to remove stale documents and rebuild sessions whose source identity changed. Old index entries without an identity remain hidden until that session is reindexed. Query state is captured before asynchronous source checks so a concurrent read-only refresh cannot cause access to a closed database handle.

There is no deletion ledger, expiry window, background deletion retry, or cross-process acknowledgement protocol. This change validates indexed search results when queried; it does not synchronously erase every disk copy or retract responses from queries already in progress. The separate live-transcript search path is unchanged. Physical index cleanup still requires a successful writer sync, while stale indexed rows cannot bypass the source check.

Validation

Full kap-server suite: 1,324 passed, 1 pre-existing skip. Final search suites including unavailable-identity and stalled-source regressions: 159 passed.
A combined integration smoke test with feat(kap-server): expose session deletion with serialized cleanup #3630 passed: real REST deletion, a stale read-only search worker, deleted journal removal, WebSocket notification/re-subscription, and same-ID recreation.
kap-server TypeScript check, root lint, and comment policy passed (existing warnings, no errors).
Regressions cover worker and inline backends, read-only stale views without a writer sync, filtering before pagination, same-ID recreation with a stale summary, legacy-index migration, normal renames, unreadable source directories, missing filesystem identity fields and recovery, corrupt optional metadata, read-only refresh during a blocked source check, delayed source reads that succeed or fail after the query deadline, and repeated concurrent searches while one source check remains blocked.

Checklist

I have read the CONTRIBUTING document.
I have linked a related issue (external PRs: the issue must have a maintainer's /approve).
I have added tests that prove my feature works.
Ran gen-changesets skill, or this PR needs no changeset.
Ran gen-docs skill, or this PR needs no doc update. This corrects existing search behavior without adding a CLI invocation or configuration option.

changeset-bot · 2026-09-07T17:57:11Z

🦋 Changeset detected

Latest commit: c3b0da0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@moonshot-ai/kimi-code	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wbxl2000 · 2026-09-07T17:58:09Z

@codex review

pkg-pr-new · 2026-09-07T17:58:45Z

pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@c3b0da0

npx https://pkg.pr.new/@moonshot-ai/kimi-code@c3b0da0

commit: c3b0da0

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41a1f2c8eb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

wbxl2000 · 2026-09-07T18:07:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ea3c627e5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

wbxl2000 · 2026-09-07T18:17:02Z

@codex review

chatgpt-codex-connector · 2026-09-07T18:22:34Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: a30e2c8973

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

wbxl2000 · 2026-09-07T19:06:04Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a1bbdaaae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

wbxl2000 · 2026-09-07T19:25:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95c7a63d91

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

wbxl2000 · 2026-09-07T19:40:12Z

@codex review

chatgpt-codex-connector · 2026-09-07T19:46:12Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: c3b0da0127

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

fix(kap-server): verify indexed search results against session sources

41a1f2c

wbxl2000 mentioned this pull request Sep 7, 2026

feat(kap-server): expose session deletion with serialized cleanup #3630

Merged

5 tasks

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread packages/kap-server/src/search/indexCore.ts Outdated

fix(kap-server): reject unverifiable search source identities

3ea3c62

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread packages/kap-server/src/search/indexCore.ts Outdated

fix(kap-server): bound search source checks by the query deadline

a30e2c8

wbxl2000 mentioned this pull request Sep 7, 2026

feat(kap-server): expose permanent session deletion via :delete #3544

Closed

chore: sync merged session deletion API

3a1bbda

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread packages/kap-server/src/search/indexCore.ts Outdated

fix(search): report sessions skipped during indexing

95c7a63

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread packages/kap-server/src/search/indexCore.ts Outdated

wbxl2000 added 2 commits September 8, 2026 03:36

fix(search): bound outstanding source identity checks

fedf9b8

refactor(search): group source check coordination state

c3b0da0

Uh oh!

Conversation

wbxl2000 commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue

Problem

What changed

Validation

Checklist

Uh oh!

changeset-bot Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

wbxl2000 commented Sep 7, 2026

Uh oh!

pkg-pr-new Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wbxl2000 commented Sep 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wbxl2000 commented Sep 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 7, 2026

Uh oh!

wbxl2000 commented Sep 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wbxl2000 commented Sep 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wbxl2000 commented Sep 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

wbxl2000 commented Sep 7, 2026 •

edited

Loading

changeset-bot Bot commented Sep 7, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 7, 2026 •

edited

Loading