fix: delete deployment files, migrate npm to yarn & make lint pass in all packages #46
+4,894
−5,193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 4 files 262 suites 9m 20s ⏱️ Results for commit 6c19bed. ♻️ This comment has been updated with latest results. |
API E2E Test Results207 tests 207 ✅ 18s ⏱️ Results for commit 6c19bed. ♻️ This comment has been updated with latest results. |
tomimor
changed the title
fix lint for worker
fix lint for app
removed non used chunk of code in app
lint fixes
lint fixes
tomimor
force-pushed
the
delete-deployments
branch
from
8197a75 to
629a760
Compare
versions updated to make typecheck pass
tons of type errors fixed
fixed some tests
fixed some tests
…ble zero skipping original explorer tests that do not apply to double zero.
skip typecheck in ci.
lint fixes
try to set env variables by hand
skip 1 extra test.
aon
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deployment-related jobs:
[x] Deletes all related deployment files from the project:
.github/workflows/app-deploy-feature-branch.yml.github/workflows/app-deploy-preview.yml.github/workflows/app-deploy-prod.yml.github/workflows/release.ymlChanges to preserve as much of the original CI as possible
[x] Migrate npm to yarn
[x] Make lint pass in all packages
[x] Skip typecheck in app. To make this check pass, we need to upgrade libraries that introduce breaking changes.
[x] Add env variables necessary to build the app in the CI.
[x] Skip some tests from upstream explorer that break with the PoC of Double Zero explorer. These tests are mainly applied for other uses of the explorer or cases where further development out of scope would be needed to make these checks pass.