This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add support for setting a custom fragment shader in RenderState #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
approved these changes
Feb 28, 2019
bluemarvin
reviewed
Feb 28, 2019
include/vrb/CreationContext.h
Outdated
| @@ -26,6 +26,7 @@ class CreationContext { | |||
| void UpdateResourceGL(); | |||
| void AddResourceGL(ResourceGL* aResource); | |||
| void AddUpdatable(Updatable* aUpdatable); | |||
| vrb::TextureCachePtr GetTextureCache() const; | |||
There was a problem hiding this comment.
Okay, I see how it is used in MozillaReality/FirefoxReality#980
I wonder it would be better to add GetDefaultTexture() instead so that the TextureCache isn't made public? It's only in the RenderContext so it can be passed to the CreationContext.
MortimerGoro
force-pushed
the
custom_fragment_shader
branch
from
5366c81 to
d802130
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.