refactor: keep org→token map out of git (host-mounted map + convention)#12
Merged
Merged
Conversation
Router no longer hardcodes org names: resolve the token env var via a host map file (~/.config/devcontainer/github-token-map), else the <ORG>_GITHUB_TOKEN convention, else GITHUB_TOKEN. Scrub org/client names from the docs so they never enter a child repo's history. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #11. The credential router previously hardcoded org names (a
casewith the real orgs), which meant the client list landed in the git history of every repo built from this template. This removes them: the helper is now fully generic and resolves the token env var per org by:~/.config/devcontainer/github-token-map(mounted read-only, not in git) —org=ENV_VAR_NAMElines, for tokens whose name doesn't follow the convention.<ORG>_GITHUB_TOKEN(org upper-cased, non-alphanumeric →_).GITHUB_TOKEN.Why
Keeps client/org names out of every descendant's history. New children never inherit them (init wipes history; sync copies current content), so scrubbing here means they're gone going forward.
Changed
git-credential-org-router.sh— generic resolver (map → convention → fallback); no org names.setup-git-credentials.sh— generic echo.AUTH-PERSISTENCE.md/secrets.example— describe the mechanism + host map file; org names removed.Token values are still read from env at push time and never written to disk.
🤖 Generated with Claude Code