Open
Conversation
15 tasks
…pass with updated examples
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…ompile-time NameError
…orms, and under uniform scaling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve consistency, usability, and feature completeness of the
mupt.geometrymodule, especially as pertains toBoundedShape, as well as strengthening array-related typing.Todos
Notable points that this PR has either accomplished or will accomplish.
visualize()interface with thin mpl wrappermupt-examplesQuestions
Should a NullShape class be implemented to avoid NoneType sentinels for unset.shapefields on Primitive?Is it worth adding support for arbitrary mapped labels to points inPointCloud.positions, rather than just int indices?DEV: opting for no on both questions
Status