Refactor SAAMR topology traversal for MDAnalysis/RDKit exporters#58
Open
joelaforet wants to merge 4 commits into
Open
Refactor SAAMR topology traversal for MDAnalysis/RDKit exporters#58joelaforet wants to merge 4 commits into
joelaforet wants to merge 4 commits into
Conversation
This was referenced May 5, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
joelaforet
commented
May 8, 2026
Contributor
Author
joelaforet
left a comment
There was a problem hiding this comment.
No comments on this one, happy to answer any questions/confusions.
12 tasks
This was
linked to
issues
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mupt.interfaces._shared.Stack Position
This is PR 1 of 3 in the role-aware RDKit/SDF export stack.
Stack:
mupt.muptio.sdfwriter.After This Merges
After merging this PR into
main:issue-51/shared-saamr-topology-indexto basemain.maininto Add role-aware RDKit molecule export #59's branch, resolve, and push.Verification
python -m pytest mupt/tests/interfaces/test_shared_topology.py -qpython -m pytest mupt/tests/interfaces/mdanalysis/test_exporters.py -q