Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Drawer #175

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update Drawer #175

wants to merge 5 commits into from

Conversation

versile2
Copy link

Updates to App Drawer to ensure size stays regardless of resizing the screen. Changed text to MudAvatar, added cache busting to index serve as well as a way to manually clear compiler cache.

@henon
Copy link
Collaborator

henon commented Jan 21, 2025

How does it look like?

@versile2
Copy link
Author

versile2 commented Jan 21, 2025

apart from having the samples and static assets looks just like https://try.arctechonline.tech

Biggest difference are the avatar letters and the appbar not being weird with resizing. Also added in compiler cache refresh.

Picture from arctech copy-
image

@henon
Copy link
Collaborator

henon commented Jan 21, 2025

Can you make the this snippet isn't compiled yet into an alert as well? I always wanted to do this but was just too lazy to spin up a PR for that

@versile2
Copy link
Author

Can you make the this snippet isn't compiled yet into an alert as well? I always wanted to do this but was just too lazy to spin up a PR for that

Just so I'm sure I'm 100% what you are discussing, this?
image

@henon
Copy link
Collaborator

henon commented Jan 21, 2025

yeah, exactly! add the second sentence too, sorry for having been vage

@versile2
Copy link
Author

image

@henon
Copy link
Collaborator

henon commented Jan 21, 2025

Btw, red on blue is rarely a good design choice. The reason is that the difference in wavelengths of red and blue which are on the opposite far ends of the visual spectrum make it impossible for your eye to focus on both colors which makes that color combination hurt the eyes or cause it to flimmer.

image

Maybe just doing white outlined circles without a fill color would look better. But I'll leave it entirely to @Garderoben to decide on design changes.

@versile2
Copy link
Author

I'm fine however you like it, I just didn't love the plain text going down although this one isn't much different at least it feels different.

image

@mikes-gh
Copy link

Not a fan of the avatar look sorry :-)

@mikes-gh
Copy link

Feels like were trying to fix the vertical text which im not a fan of either.

@versile2
Copy link
Author

no need to be sorry, you prefer the plain vertical text going down or have any other suggestions? I can just revert it.

@versile2
Copy link
Author

versile2 commented Feb 1, 2025

@Garderoben what do you want for the text down, just like it was or with the avatar look white? or something different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants