Develop steelfeel #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to solidity 0.8.0
Updated to Solidity 0.8.0
Updated the Artist contract to use $MUSIC for tips and payouts. I still have some questions inline which can be found in the comments prefixed by "//rw"
Updated the PayPerPlay contract to work with $MUSIC instead of ETH. I also removed all the PENDING payment code as this shouldnt be an issue now that gas is not part of the network. If the callback receive() function receives ETH, so I'm not sure what the implications of that are and if it shouldn't accept any ETH now that everything should be running on $MUSIC for the end user and not ETH
Removed the received() fallback function for accepting ETH payments. It is not required and the accounting becomes confusing because of the mixed $MUSIC / ETH currencies if it is accepted. Distribution would then have to work with both ETH and $MUSIC when in fact this contract should only be receiving $MUSIC
Fixed some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.