Conversation
Launcher label was memory_app; it now reads Memory, matching the wordmark the app shows everywhere else. The icon is the ghost on the loading-screen yellow: an adaptive icon (yellow background + padded foreground so no launcher mask clips the tail) with legacy square and round PNGs for older launchers. The login screen drops its textured painter for the same flat accent the splash fills, and the logo stops breathing and blinking -- the first frame after the splash should look like the splash settling, not a new animation. Password fields now opt out of the keyboard's help: with suggestions and autocorrect left on, Gboard and Samsung's keyboard rewrite the hidden value as you type, so the password sent was not the one keyed. Obscured fields also switch to the password keyboard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The button sized itself with a ConstrainedBox that set only a minimum, then centred the glyph inside it. A Center given only a minimum grows to whatever maximum width it is offered: in a Row that maximum is unbounded, so it shrink-wrapped to the 48dp target and looked correct -- but as a TextField's suffixIcon, InputDecorator offers the full field width, so the eye button expanded across the entire field. The password input became one big reveal button with no room to type. Size to a definite square (max of the visual size and the 48dp target) instead, so the hit target is fixed everywhere and never eats the field. Regression test measures the suffix width inside a real InputDecorator and confirms the field stays typable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Login and create-account both drew their forms on a white, shadowed card floating over the background. Drop the cards: the fields are already their own dark slabs, so a white panel behind them only boxed the screen in. The forms now sit straight on the accent yellow. Login: more air before the actions (a new xxxl spacing step, since a section gap read as too tight between the last field and the buttons), and the Create account button is now white with black text instead of cream. Create account: same flat accent as login -- the textured background painter and its scattered icons are gone (the painter, now unused, is deleted) -- and the step forms are centered, capped at a readable width, matching login. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The login and splash lead with the logo; the sign-up flow started cold with just the step header. Add the same logo, centered above the form so it stays branded on every step, matching the two screens either side of it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
On boot UsersService fires backfillNormalizedPhones as a fire-and-forget job. Because the pg driver adapter connects lazily, that backfill's first query is what actually reaches the database -- so when pm2 starts the API before the Postgres container is accepting connections, it fails with P1001 "can't reach database server", logs an ERROR, and skips the backfill for that whole boot. The app itself starts fine, so this was pure noise plus a missed backfill. Retry the backfill with capped exponential backoff (up to 10 attempts) while the error looks like an unreachable database (P1001/P1002, or the message as a fallback), logging a warning between tries. A non-connection error, or running out of attempts, still escalates to a single ERROR as before. Adds a DB-free unit spec under src/ (so `npm test` actually runs it) covering the retry, the message-only detection, and immediate escalation of a real query error. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (15)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThe changes improve startup database backfill resilience, refresh authentication screen layouts, adjust design-system input behavior and spacing, add an icon sizing regression test, and update Android launcher branding. ChangesBackend startup resilience
Authentication interface refresh
Design-system input and spacing updates
Android launcher branding
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit