fix(backend,contract): listCreators chain merge, JwtAuthGuard test wiring, cargo audit exceptions, treasury SorobanError scope#831
Merged
Conversation
…ring, cargo audit exceptions, treasury SorobanError scope
|
@success-OG Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
aji70
added a commit
that referenced
this pull request
Apr 30, 2026
fix(backend,contract): listCreators chain merge, JwtAuthGuard test wiring, cargo audit exceptions, treasury SorobanError scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #583
closes #584
closes #599
closes #610
PR description:
fix: resolve merge conflict remnants, add listCreators with chain merge, wire JwtAuthGuard in tests, document cargo audit exceptions, and fix SorobanError scope in treasury tests
Task 1 (CreatorsService listCreators / chain merge): Removed stray git merge branch names (
treasury-deposit-event,main) left insubscriptions.service.tsthat were breaking TypeScript compilation. AddedlistCreators(mergeChain?)toCreatorsService— whenmergeChain=trueit reads each plan from the Soroban contract viaSubscriptionChainReaderService, compares against the in-memoryplanMap, and annotates each plan withsyncStatus: 'synced' | 'stale' | 'unknown'. Chain reads are best-effort; disconnected/invalid states fall back tounknown. WiredSubscriptionChainReaderServiceas an optional dependency. AddedGET /creators/list?chain=trueendpoint. Added unit tests covering all branches.Task 2 (JwtAuthGuard in creators.controller.ts): Imports were already correct. Fixed the controller spec which was failing because
JwtAuthGuardran during tests — added.overrideGuard(JwtAuthGuard).useValue({ canActivate: () => true })to the test module. AddedlistCreatorsmock and tests to the controller spec.Task 3 (cargo audit exceptions): Documented
RUSTSEC-2024-0436(paste — unmaintained, compile-time only, transitive via soroban-sdk) andRUSTSEC-2026-0012(keccak — unsound ARMv8 assembly, not reachable from wasm32 target) inaudit.tomlwith full justification.cargo auditnow exits 0 in CI.Task 4 (SorobanError scope in treasury tests): Replaced
Error as SorobanErrorimport alias with directsoroban_sdk::Error::from_contract_error(...)calls throughouttreasury/src/test.rs, eliminating the naming ambiguity with the localErrorenum brought in byuse super::*. All 11 treasury tests pass.