Skip to content

[BUGFIX] Allow comma in quoted string in selector #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] Allow comma in quoted string in selector #1323

wants to merge 1 commit into from
+21 −6

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jul 9, 2025

Split by commas during parsing, not after.

@JakeQZ JakeQZ requested a review from oliverklee July 9, 2025 23:20
@JakeQZ JakeQZ self-assigned this Jul 9, 2025
@JakeQZ JakeQZ mentioned this pull request Jul 9, 2025
Open
@JakeQZ JakeQZ force-pushed the bugfix/selector-comma branch from f027b43 to 0c768e5 Compare July 10, 2025 00:39
@coveralls
Copy link

coveralls commented Jul 10, 2025 •
edited
Loading

Coverage Status

coverage: 58.615% (+0.2%) from 58.397%
when pulling 077a10e on bugfix/selector-comma
into 595a47b on main.

@JakeQZ
[BUGFIX] Allow comma in quoted string in selector
077a10e 
Split by commas during parsing, not after.
@JakeQZ JakeQZ force-pushed the bugfix/selector-comma branch from 0c768e5 to 077a10e Compare July 10, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee Awaiting requested review from oliverklee

At least 1 approving review is required to merge this pull request.

Assignees

@JakeQZ JakeQZ

Labels
bug to-backport
Projects
None yet
Milestone
8.9.0: Deprecations and bug fixes
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeQZ @coveralls