rpc benchmark: script to pull Grafana logs #20911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
changed the title
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
approved these changes
Jan 29, 2025
Comment on lines
+55
to
+72
| async fn fetch_logs( | ||
| client: &reqwest::Client, | ||
| url: &str, | ||
| query: &str, | ||
| start: &str, | ||
| end: &str, | ||
| limit: u64, | ||
| offset: Option<u64>, | ||
| ) -> Result<LokiResponse, Box<dyn Error>> { | ||
| let mut params = vec![ | ||
| ("query".to_string(), query.to_string()), | ||
| ("start".to_string(), start.to_string()), | ||
| ("end".to_string(), end.to_string()), | ||
| ("limit".to_string(), limit.to_string()), | ||
| ]; | ||
| if let Some(o) = offset { | ||
| params.push(("start_from".to_string(), o.to_string())); | ||
| } |
There was a problem hiding this comment.
this is mainly when we're benchmarking against a remote jsonrpc service right? if we were to benchmark jsonrpc locally, then we can pull from the local metrics service or something like that directly?
amnn
approved these changes
Jan 31, 2025
| message: String, | ||
| } | ||
|
|
||
| fn extract_body_from_message(message: &str) -> Option<String> { |
There was a problem hiding this comment.
Please add doc comments explaining the format that you are parsing here, and for fetch_logs.
| .with_env() | ||
| .init(); | ||
| if let Err(e) = run().await { | ||
| error!("Error: {}", e); |
There was a problem hiding this comment.
Suggested change
| error!("Error: {}", e); | |
| error!("{e}"); |
| let mut writer = BufWriter::new(file); | ||
|
|
||
| for (method, bodies) in method_map { | ||
| info!("Writing {} logs for method: {}", bodies.len(), method); |
There was a problem hiding this comment.
Suggested change
| info!("Writing {} logs for method: {}", bodies.len(), method); | |
| info!(len=bodies.len(), method, "Writing logs"); |
Comment on lines
+193
to
+195
| let line = format!(r#"{{"method":"{}", "body":{}}}"#, method, body); | ||
| writer.write_all(line.as_bytes())?; | ||
| writer.write_all(b"\n")?; |
There was a problem hiding this comment.
There's no need to allocate for the line before writing it out.
Suggested change
| let line = format!(r#"{{"method":"{}", "body":{}}}"#, method, body); | |
| writer.write_all(line.as_bytes())?; | |
| writer.write_all(b"\n")?; | |
| write!(writer, r#"{{"method":"{method}", "body":"#)?; | |
| writer.write_all(body.as_bytes())?; | |
| write!(writer, "}}\n")?; |
| let mut method_map: HashMap<String, Vec<String>> = HashMap::new(); | ||
| for log_entry in all_logs { | ||
| if let Some(body_content) = extract_body_from_message(&log_entry.message) { | ||
| if let Ok(parsed) = serde_json::from_str::<Value>(&body_content) { |
There was a problem hiding this comment.
Should we print an error if we weren't able to parse the JSON?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a stacked pr, pull sampled JSON RPC request logs from Grafana API, now a local
port-forwardis necessary to make it workTest plan
local run
the output, suix_getBalance / suix_getAllBalances are the top ones taking the majority
logged jsonl file is like
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.