[9/n][vm-rewrite][Move] Update depth calculation calculation/caching to be threadsafe #21074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-8
branch
from
b9aac05 to
eee4b44
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-9
branch
from
df609c5 to
4c8450e
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-8
branch
from
1ccd302 to
54cd0cc
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-9
branch
from
4c8450e to
e686658
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-8
branch
from
54cd0cc to
c0cde3b
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-9
branch
from
e686658 to
f52ecca
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-8
branch
from
c0cde3b to
3e31dcf
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-9
branch
from
f52ecca to
6c763a2
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…to be threadsafe Switching the depth calculation of types to be lazily evaluated when we first encountered the value, coupled with shared package cache, and the types living in this shared package cache meant that the `depth` for a type needed to be made threadsafe since we may need to write to it in a parallel context. This does this by `RwLock`ing the `depth` field and then making the changes from there.
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-8
branch
from
3e31dcf to
72813de
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-9
branch
from
6c763a2 to
aa3e12c
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching the depth calculation of types to be lazily evaluated when we first encountered the value, coupled with shared package cache, and the types living in this shared package cache meant that the
depthfor a type needed to be made threadsafe since we may need to write to it in a parallel context.This does this by
RwLocking thedepthfield and then making the changes from there.