[10/n][vm-rewrite][adapter] Update type inputs so they are always converted to runtime IDs before entering the VM #21091
+101
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-9
branch
from
e686658 to
f52ecca
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-10
branch
from
03e2002 to
1495f13
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-9
branch
from
f52ecca to
6c763a2
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-10
branch
from
1495f13 to
b5d65d5
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…verted to runtime IDs before entering the VM
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-9
branch
from
6c763a2 to
aa3e12c
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-10
branch
from
b5d65d5 to
f301cc6
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates type tags in the adapter so that whenever we pass them into the VM we first will convert them to be runtime ID-based.
We could possibly optimize this more to do this reification when we convert from a
TypeInputto aTypeTagbut I'm not wholly convinced that that is something we want to do.