-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc benchmark: log additional info for cursor handling #21099
Open
gegaowp
wants to merge
1
commit into
MystenLabs:grafana-pull
Choose a base branch
from
gegaowp:json-rpc-adapter
base: grafana-pull
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
18e6fe3
to
8636f5c
Compare
gegaowp
commented
Feb 5, 2025
8636f5c
to
5ff536b
Compare
gegaowp
commented
Feb 5, 2025
5ff536b
to
85f8a18
Compare
amnn
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would generally be good to see more documentation in this codebase -- it would help with reviews, and for maintenance. I also left some suggestions for a way to simplify cursor handling.
85f8a18
to
8a576a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add aux info to the jsonl logs for filtering and aggscript to filter wallet traffic and aggregate page-iterations for methods of["suix_getOwnedObjects", "suix_getAllCoins", "suix_getCoins"]
based on both method and params except cursor and limits.following the comment and did the adaption on the runner side, see PR #21181
and now this PR only makes some prep logging changes
Test plan
local run of grafana_pull_logs and make sure that output file is timestamp-ascending
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.