Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc benchmark: log additional info for cursor handling #21099

Open
wants to merge 1 commit into
base: grafana-pull
Choose a base branch
from

Conversation

gegaowp
Copy link
Contributor

@gegaowp gegaowp commented Feb 5, 2025

Description

add aux info to the jsonl logs for filtering and agg
script to filter wallet traffic and aggregate page-iterations for methods of ["suix_getOwnedObjects", "suix_getAllCoins", "suix_getCoins"] based on both method and params except cursor and limits.

following the comment and did the adaption on the runner side, see PR #21181

and now this PR only makes some prep logging changes

  • log header and timestamp
  • make sure the output file is timestamp asc.

Test plan

local run of grafana_pull_logs and make sure that output file is timestamp-ascending


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 11:30pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:30pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:30pm

@gegaowp gegaowp temporarily deployed to sui-typescript-aws-kms-test-env February 5, 2025 18:45 — with GitHub Actions Inactive
@gegaowp gegaowp temporarily deployed to sui-typescript-aws-kms-test-env February 5, 2025 18:47 — with GitHub Actions Inactive
Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would generally be good to see more documentation in this codebase -- it would help with reviews, and for maintenance. I also left some suggestions for a way to simplify cursor handling.

crates/sui-rpc-benchmark/src/bin/process_jsonl.rs Outdated Show resolved Hide resolved
crates/sui-rpc-benchmark/src/bin/process_jsonl.rs Outdated Show resolved Hide resolved
crates/sui-rpc-benchmark/src/bin/process_jsonl.rs Outdated Show resolved Hide resolved
crates/sui-rpc-benchmark/Cargo.toml Outdated Show resolved Hide resolved
crates/sui-rpc-benchmark/src/bin/process_jsonl.rs Outdated Show resolved Hide resolved
crates/sui-rpc-benchmark/src/bin/process_jsonl.rs Outdated Show resolved Hide resolved
crates/sui-rpc-benchmark/src/bin/process_jsonl.rs Outdated Show resolved Hide resolved
crates/sui-rpc-benchmark/src/bin/process_jsonl.rs Outdated Show resolved Hide resolved
crates/sui-rpc-benchmark/src/bin/process_jsonl.rs Outdated Show resolved Hide resolved
@gegaowp gegaowp temporarily deployed to sui-typescript-aws-kms-test-env February 11, 2025 23:25 — with GitHub Actions Inactive
@gegaowp gegaowp requested a review from amnn February 11, 2025 23:27
@gegaowp gegaowp changed the title rpc benchmark: handle JSON RPC cursor breaking change rpc benchmark: log additional info for cursor handling Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants