grpc: leverage FieldMasks for partial responses and other proto tweaks

crates/sui-e2e-tests/Cargo.toml

@@ -69,6 +69,7 @@ shared-crypto.workspace = true
 sui-sdk-types.workspace = true
 sui-sdk-transaction-builder.workspace = true
 tonic.workspace = true
+prost-types.workspace = true
 
 passkey-types.workspace = true
 passkey-client.workspace = true

crates/sui-e2e-tests/tests/rpc/checkpoints.rs

@@ -137,6 +137,7 @@ async fn get_checkpoint() {
             sequence_number: Some(sequence_number.unwrap()),
             digest: Some(digest.clone().unwrap()),
             options: None,
+            read_mask: None,
         })
         .await
         .unwrap_err();
@@ -210,6 +211,8 @@ async fn get_full_checkpoint() {
         events_bcs,
         input_objects,
         output_objects,
+        input_objects_old,
+        output_objects_old,
     } in transactions
     {
         assert!(digest.is_some());
@@ -222,8 +225,10 @@ async fn get_full_checkpoint() {
         }
         assert!(events.is_none());
         assert!(events_bcs.is_none());
-        assert!(input_objects.is_none());
-        assert!(output_objects.is_none());
+        assert!(input_objects.is_empty());
+        assert!(output_objects.is_empty());
+        assert!(input_objects_old.is_none());
+        assert!(output_objects_old.is_none());
     }
     // Ensure we found the transaction we used for picking the checkpoint to test against
     assert!(found_transaction);
@@ -266,6 +271,8 @@ async fn get_full_checkpoint() {
         events_bcs,
         input_objects,
         output_objects,
+        input_objects_old,
+        output_objects_old,
     } in transactions
     {
         assert!(digest.is_some());
@@ -278,8 +285,10 @@ async fn get_full_checkpoint() {
         }
         assert!(events.is_none());
         assert!(events_bcs.is_none());
-        assert!(input_objects.is_none());
-        assert!(output_objects.is_none());
+        assert!(input_objects.is_empty());
+        assert!(output_objects.is_empty());
+        assert!(input_objects_old.is_none());
+        assert!(output_objects_old.is_none());
     }
     // Ensure we found the transaction we used for picking the checkpoint to test against
     assert!(found_transaction);
@@ -324,6 +333,8 @@ async fn get_full_checkpoint() {
         events_bcs,
         input_objects,
         output_objects,
+        input_objects_old,
+        output_objects_old,
     } in transactions
     {
         assert!(digest.is_some());
@@ -336,23 +347,18 @@ async fn get_full_checkpoint() {
             assert!(events.is_some());
             assert!(events_bcs.is_some());
         }
-        assert!(input_objects.is_some());
-        assert!(output_objects.is_some());
+        assert!(!input_objects.is_empty());
+        assert!(!output_objects.is_empty());
+        assert!(input_objects_old.is_some());
+        assert!(output_objects_old.is_some());
 
         for FullCheckpointObject {
             object_id,
             version,
             digest,
             object,
             object_bcs,
-        } in input_objects
-            .iter()
-            .flat_map(|objects| objects.objects.iter())
-            .chain(
-                output_objects
-                    .iter()
-                    .flat_map(|objects| objects.objects.iter()),
-            )
+        } in input_objects.iter().chain(output_objects.iter())
         {
             assert!(object_id.is_some());
             assert!(version.is_some());
@@ -396,6 +402,7 @@ async fn get_full_checkpoint() {
             sequence_number: Some(sequence_number.unwrap()),
             digest: Some(digest.clone().unwrap()),
             options: None,
+            read_mask: None,
         })
         .await
         .unwrap_err();
@@ -415,8 +422,14 @@ async fn subscribe_checkpoint() {
         .await
         .unwrap();
 
+    let request = SubscribeCheckpointsRequest {
+        read_mask: Some(prost_types::FieldMask {
+            paths: vec!["sequence_number".to_owned()],
+        }),
+    };
+
     let mut stream = client
-        .subscribe_checkpoints(SubscribeCheckpointsRequest::default())
+        .subscribe_checkpoints(request)
         .await
         .unwrap()
         .into_inner();

crates/sui-e2e-tests/tests/rpc/execute.rs

@@ -50,7 +50,7 @@ async fn execute_transaction_transfer() {
     ];
     expected.sort_by_key(|e| e.address);
 
-    let mut actual = response.balance_changes.unwrap();
+    let mut actual = response.balance_changes;
     actual.sort_by_key(|e| e.address);
 
     assert_eq!(actual, expected);

crates/sui-e2e-tests/tests/rpc/resolve.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Mysten Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
+use prost_types::FieldMask;
 use shared_crypto::intent::Intent;
 use sui_keys::keystore::AccountKeystore;
 use sui_macros::sim_test;
@@ -20,10 +21,16 @@ fn build_resolve_request(
     transaction: &unresolved::Transaction,
     simulate: bool,
 ) -> ResolveTransactionRequest {
+    let read_mask = if simulate {
+        Some(FieldMask {
+            paths: vec!["simulation".to_string()],
+        })
+    } else {
+        None
+    };
     ResolveTransactionRequest {
         unresolved_transaction: Some(serde_json::to_string(transaction).unwrap()),
-        simulate: Some(simulate),
-        simulate_options: None,
+        read_mask,
     }
 }
 

crates/sui-e2e-tests/tests/rpc/transactions.rs

@@ -41,8 +41,8 @@ async fn get_transaction() {
     assert!(digest.is_some());
     assert!(transaction.is_none());
     assert!(transaction_bcs.is_none());
-    assert!(signatures.is_none());
-    assert!(signatures_bytes.is_none());
+    assert!(signatures.is_empty());
+    assert!(signatures_bytes.is_empty());
     assert!(effects.is_none());
     assert!(effects_bcs.is_none());
     assert!(events.is_none());
@@ -75,8 +75,8 @@ async fn get_transaction() {
     assert!(digest.is_some());
     assert!(transaction.is_none());
     assert!(transaction_bcs.is_none());
-    assert!(signatures.is_none());
-    assert!(signatures_bytes.is_none());
+    assert!(signatures.is_empty());
+    assert!(signatures_bytes.is_empty());
     assert!(effects.is_none());
     assert!(effects_bcs.is_none());
     assert!(events.is_none());
@@ -111,8 +111,8 @@ async fn get_transaction() {
     assert!(digest.is_some());
     assert!(transaction.is_some());
     assert!(transaction_bcs.is_some());
-    assert!(signatures.is_some());
-    assert!(signatures_bytes.is_some());
+    assert!(!signatures.is_empty());
+    assert!(!signatures_bytes.is_empty());
     assert!(effects.is_some());
     assert!(effects_bcs.is_some());
     assert!(events.is_some());

crates/sui-rpc-api/buf.yaml

@@ -13,6 +13,10 @@ modules:
       ignore_only:
         PACKAGE_VERSION_SUFFIX:
           - proto/sui/types
+        ENUM_VALUE_PREFIX:
+          - proto/sui/types/signature_scheme.proto
+        ENUM_ZERO_VALUE_SUFFIX:
+          - proto/sui/types/signature_scheme.proto
 
       enum_zero_value_suffix: _UNKNOWN
       rpc_allow_same_request_response: false