Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sui system] SIP-39 (reroll) #21303

Merged
merged 40 commits into from
Apr 2, 2025
Merged

[sui system] SIP-39 (reroll) #21303

merged 40 commits into from
Apr 2, 2025

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Feb 21, 2025 •
edited
Loading

Description

Test plan

  • Features tests for new functions.

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol: Implements SIP-39 in Sui System
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env February 21, 2025 09:57 — with GitHub Actions Inactive
@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 7:41am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 7:41am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 7:41am

@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env February 21, 2025 10:05 — with GitHub Actions Inactive
@damirka damirka self-assigned this Feb 21, 2025
@damirka damirka requested a review from emmazzz February 21, 2025 10:07
@damirka damirka marked this pull request as ready for review February 21, 2025 10:07
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env February 21, 2025 10:07 — with GitHub Actions Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env February 21, 2025 12:15 — with GitHub Actions Inactive
tnowacki
tnowacki reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is our test plan for this? I see new unit tests but do we have end to end test coverage?

@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env February 26, 2025 08:11 — with GitHub Actions Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 5, 2025 16:50 — with GitHub Actions Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 6, 2025 10:28 — with GitHub Actions Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 17, 2025 14:48 — with GitHub Actions Inactive
@damirka damirka requested a review from ronny-mysten as a code owner March 18, 2025 09:34
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 18, 2025 09:34 — with GitHub Actions Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 18, 2025 12:56 — with GitHub Actions Inactive
damirka and others added 23 commits April 2, 2025 10:38
@damirka
fix comment in tests
5809c13
@damirka
fix move test breaking
06987b9
@damirka
fix dynamic commitee tests
ba5c018
@damirka
fix rounding error in checks
1386332
@damirka
remove legacy comment
cda809f
@damirka
restore original value to not break other snapshots
9283aec
@damirka @emmazzz
Update crates/sui-e2e-tests/tests/reconfiguration_tests.rs
03ae997 
Co-authored-by: Emma Zhong <[email protected]>
@damirka
post-review fixes
3b47676
@damirka
more comments, closer to the SIP-39
37d05b1
@damirka
-> derive_raw_voting_power
26743b1
@damirka
adds protocol version change test
1380634
@damirka
adds fixed protocol version - change it if merged too late
cd1234b
@damirka
fix concurrency issue
ae330b3
@damirka
snapshots update
54b3f59
@damirka
upd snapshots
b6ec3ef
@damirka
fix tests after changing >= to >
09c73fa
@damirka
better comments and tests cleanup
8ce6a58
@damirka
update snapshots
97c0c3a
@damirka
updates snapshots for protocol version 80
80c5dd0
@damirka
adds immediate kick out test
324bbdf
@damirka
reconfiguration tests
ba4d2e9
@damirka
review patches
5e95326
@damirka
update docs
ace35be
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env April 2, 2025 07:40 — with GitHub Actions Inactive
@damirka damirka merged commit a1213f8 into main Apr 2, 2025
49 of 51 checks passed
@damirka damirka deleted the ds/sip-39 branch April 2, 2025 08:21
This was referenced Apr 2, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxfind lxfind lxfind approved these changes

@tnowacki tnowacki tnowacki left review comments

@sblackshear sblackshear sblackshear approved these changes

@emmazzz emmazzz emmazzz approved these changes

@manolisliolios manolisliolios manolisliolios approved these changes

@mystenmark mystenmark mystenmark approved these changes

@dariorussi dariorussi dariorussi approved these changes

@rjs-mysten rjs-mysten Awaiting requested review from rjs-mysten

@ronny-mysten ronny-mysten Awaiting requested review from ronny-mysten ronny-mysten is a code owner

Assignees

@damirka damirka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@damirka @lxfind @tnowacki @sblackshear @emmazzz @manolisliolios @mystenmark @dariorussi