Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formatter] bugs & fixes #21381

Merged
merged 26 commits into from
Apr 4, 2025
Merged

[formatter] bugs & fixes #21381

merged 26 commits into from
Apr 4, 2025

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Feb 28, 2025

Description

  • dot_expression now supports trailing comment in a list
  • a single element of an arg_list can have trailing line comment
  • a single element of an arg_list can have leading line comment
  • trailing comment no longer breaks vector_expression

if_expression:

  • indentation fixed in certain places
  • if-else chain is a special behavior

Test plan

Features tests for all the cases.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@damirka damirka requested a review from awelc February 28, 2025 11:34
@damirka damirka self-assigned this Feb 28, 2025
Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 3:44pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 3:44pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 3:44pm

@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env February 28, 2025 11:34 — with GitHub Actions Inactive
@damirka damirka requested review from tedks and dariorussi February 28, 2025 11:34
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 3, 2025 11:22 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 3, 2025 11:22 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 3, 2025 11:22 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 3, 2025 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 3, 2025 12:28 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 3, 2025 12:29 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 3, 2025 13:06 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 3, 2025 13:06 Inactive
@damirka damirka had a problem deploying to sui-typescript-aws-kms-test-env March 3, 2025 13:06 — with GitHub Actions Failure
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 3, 2025 13:09 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 3, 2025 13:09 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 3, 2025 13:09 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 5, 2025 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 5, 2025 14:29 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 5, 2025 14:29 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk March 5, 2025 14:58 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit March 5, 2025 14:58 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env March 5, 2025 14:58 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk April 3, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit April 3, 2025 16:30 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env April 3, 2025 16:30 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk April 3, 2025 18:52 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit April 3, 2025 18:52 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env April 3, 2025 18:52 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit April 3, 2025 19:04 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk April 3, 2025 19:04 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env April 3, 2025 19:04 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit April 3, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk April 3, 2025 20:14 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env April 3, 2025 20:14 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit April 4, 2025 15:37 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk April 4, 2025 15:37 Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env April 4, 2025 15:37 — with GitHub Actions Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env April 4, 2025 15:43 — with GitHub Actions Inactive
@damirka damirka merged commit e9ec593 into main Apr 4, 2025
46 of 47 checks passed
@damirka damirka deleted the ds/formatter-improvements branch April 4, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants