-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[indexer-alt][db-agnostic-framework][5/n] fully parameterize sui-indexer-alt-framework #21652
Closed
wlmyng
wants to merge
9
commits into
move-watermarks-out-of-indexer-framework
from
parameterize-indexer-alt
Closed
[indexer-alt][db-agnostic-framework][5/n] fully parameterize sui-indexer-alt-framework #21652
wlmyng
wants to merge
9
commits into
move-watermarks-out-of-indexer-framework
from
parameterize-indexer-alt
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hema, and functionality is in a handler in indexer-alt
pull in finalized store trait, and pg store implementation, to demonstrate interface and usage within the framework
…o the Connection trait will make it easier to lift this out of the framework later
…lf.pruner_hi, it caused the pruner to stagnate. because it wasnt advancing its own pruner_hi
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
00930f9
to
a38d882
Compare
acb55ce
to
f4a855f
Compare
a38d882
to
fa472c0
Compare
…t provides the generic store traits, and people can opt-in using features
eab714a
to
5eafb90
Compare
Okay, I think we've fully parameterized?
853c188
to
3a20d75
Compare
5eafb90
to
fabcf2a
Compare
3f8af15
to
2636c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.