-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Implement transfers out of ConsensusV2 #21683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed top commit only, since this appears to be a stack.
One suggestion + approved.
)), | ||
IDOperation::None, | ||
) => Some((*id, self.lamport_version, *object_digest)), | ||
_ => None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider
match (
&change.input_state,
&change.output_state,
&change.id_operation,
) {
(
ObjectIn::Exist((_, Owner::ConsensusV2 { .. })),
ObjectOut::ObjectWrite((object_digest, Owner::ConsensusV2 { .. })),
IDOperation::None,
) => None,
(
ObjectIn::Exist((_, Owner::ConsensusV2 { .. })),
ObjectOut::ObjectWrite((object_digest, _)),
IDOperation::None,
) => Some((*id, self.lamport_version, *object_digest)),
_ => None,
}
as a more future proof alternative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on how this is more future-proof? If we introduce a new Owner type, there's no way of knowing in advance whether it will be a consensus type or a fastpath type.
We need to write ConsensusStreamEnded marker any time a consensus object is transferred out of consensus. (Right now this is only done when it's deleted or wrapped but not otherwise.) Stacked on #21665
b8e1207
to
c86069b
Compare
We need to write ConsensusStreamEnded marker any time a consensus object is transferred out of consensus. (Right now this is only done when it's deleted or wrapped but not otherwise.)
Stacked on #21665
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.