Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vm][move-vm][rewrite] Add message for VM errors when available in transactional tests #21702

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

cgswords
Copy link
Contributor

@cgswords cgswords commented Apr 3, 2025

Description

Add message for VM errors when available in transactional tests

Test plan

Tests updated


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@cgswords cgswords requested review from tnowacki and tzakian April 3, 2025 00:31
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 0:35am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Apr 3, 2025 0:35am
sui-kiosk ⬜️ Ignored (Inspect) Apr 3, 2025 0:35am

Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, although I'm confused as to why the header insta heads on some tests changed? (doesn't seem like an issue with this PR, just more generally confused about why it changed)

@cgswords cgswords changed the title https://github.com/MystenLabs/sui/pull/21650/files [vm][move-vm][rewrite] Add message for VM errors when available in transactional tests Apr 4, 2025
@cgswords cgswords merged commit 08eb70b into bella-ciao Apr 5, 2025
35 of 46 checks passed
@cgswords cgswords deleted the cgswords/message_error_vm_tests branch April 5, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants