[typed store] enable iterator methods for in_memory_db and tidehunter #21709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
andll
approved these changes
Apr 7, 2025
| @@ -544,8 +544,7 @@ impl ObjectStore for AuthorityPerpetualTables { | |||
| } | |||
|
|
|||
| pub struct LiveSetIter<'a> { | |||
| iter: | |||
| <DBMap<ObjectKey, StoreObjectWrapper> as Map<'a, ObjectKey, StoreObjectWrapper>>::SafeIterator, | |||
| iter: Box<dyn Iterator<Item = Result<(ObjectKey, StoreObjectWrapper), TypedStoreError>> + 'a>, | |||
There was a problem hiding this comment.
You can make a type alias in typed-store crate for this iterator since it seem to repeat very often.
Something like
type DbIterator<T> = Box<dyn Iterator<Item = Result<T, TypedStoreError>>>
crates/typed-store/src/util.rs
Outdated
| use typed_store_error::TypedStoreError; | ||
|
|
||
| #[inline] | ||
| pub fn be_fix_int_ser<S>(t: &S) -> Result<Vec<u8>, TypedStoreError> |
There was a problem hiding this comment.
Seeing that in all call sites of this function we just call expect on the results, perhaps it makes sense to just call expect inside of this function and not return Result?
phoenix-o
force-pushed
the
ts_th_iterators0
branch
from
9dbbf5e to
4c52210
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR enables iterator methods for in_memory_db and tidehunter
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.