Revised SM DA codes for Noah39 and NoahMP401 #1694
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkemp
added
enhancement
This includes removing the loop where icy grid points have their DA values reset to Noah. This is redundant with code further down (DA updates are only applied to non-icy points).
NOTE: New files have "sm1" in filename. In future, will rename to remove the "sm1" (and replace the earlier Noah and NoahMP SM DA attrib files used in Ops), but this should be tested first.
Note that in practice this was a fresh rewrite from Wanshu's original code.
I basically started over from Wanshu's original code and made updates.
The max and min SM thresholds are functions of local soil type, and need to be set before the rescaling subroutine is called.
|
This PR will not be added to LIS 7.6 due to development time/testing required. It may go into LIS 7.7. I will keep it here for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge in revised single-soil layer SM DA codes for NoahMP401 and Noah39. Based on NoahMP401 experimental code
developed/testesd by Sujay Kumar and Wanshu Nie.
NOT READY for merger yet.