Skip to content

NASA-PDS/validate#1241: patch to use local file instead of attempting to download URL#188

Merged
jordanpadams merged 2 commits intomainfrom
validate_1241
Jan 10, 2026
Merged

NASA-PDS/validate#1241: patch to use local file instead of attempting to download URL#188
jordanpadams merged 2 commits intomainfrom
validate_1241

Conversation

@al-niessner
Copy link
Copy Markdown
Contributor

@al-niessner al-niessner commented Jan 8, 2026

🗒️ Summary

Use local file if protocol is of type file.

⚙️ Test Data and/or Report

Running against very large GEO product off line. Also, validate unit tests will need to work on PR NASA-PDS/validate# once a new jparser snapshot is released. Works locally using latest code as a precursor that it should be just fine.

♻️ Related Issues

NASA-PDS/validate#1241

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Documentation

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.

Maintenance

  • Issue Traceability: The PR is linked to a valid GitHub Issue or Jira Ticket.
  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

jparser was treating all items as remote and downloading them despite the URL protocol. Applied a patch that uses the local file rather than download/copy it to /tmp.

Also updated the POM to rid eclipse errors of multiple resolutions of java.xml now that we are onto java 17.
@al-niessner al-niessner requested a review from a team as a code owner January 8, 2026 18:27
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 8, 2026

@al-niessner
Copy link
Copy Markdown
Contributor Author

@jordanpadams @tloubrieu-jpl

Please build and release this snapshot. Once done let me know and I will update the validate stuff to make sure that those tests complete successfully as well. Although it appears to have been run here as well so we should be in good shape.

Also,, there is something unstable in your testing of this repo. I had to rerun 17 because it failed the first time. No code changes, just re-run.

Copy link
Copy Markdown
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist: ✓
Code delta: ✓
GitHub checks: ✓
Local test suite: ✓
Approval: ✅
Local details:

[INFO] Tests run: 673, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

@jordanpadams jordanpadams changed the title validate 1241: patch to use local NASA-PDS/validate#1241: patch to use local Jan 10, 2026
@jordanpadams jordanpadams changed the title NASA-PDS/validate#1241: patch to use local NASA-PDS/validate#1241: patch to use local file instead of attempting to download URL Jan 10, 2026
@jordanpadams jordanpadams merged commit b056772 into main Jan 10, 2026
5 of 6 checks passed
@jordanpadams jordanpadams deleted the validate_1241 branch January 10, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants