NASA-PDS/validate#1241: patch to use local file instead of attempting to download URL#188
Merged
jordanpadams merged 2 commits intomainfrom Jan 10, 2026
Merged
NASA-PDS/validate#1241: patch to use local file instead of attempting to download URL#188jordanpadams merged 2 commits intomainfrom
jordanpadams merged 2 commits intomainfrom
Conversation
jparser was treating all items as remote and downloading them despite the URL protocol. Applied a patch that uses the local file rather than download/copy it to /tmp. Also updated the POM to rid eclipse errors of multiple resolutions of java.xml now that we are onto java 17.
|
Contributor
Author
|
Please build and release this snapshot. Once done let me know and I will update the validate stuff to make sure that those tests complete successfully as well. Although it appears to have been run here as well so we should be in good shape. Also,, there is something unstable in your testing of this repo. I had to rerun 17 because it failed the first time. No code changes, just re-run. |
nutjob4life
approved these changes
Jan 8, 2026
Member
nutjob4life
left a comment
There was a problem hiding this comment.
Reviewer checklist: ✓
Code delta: ✓
GitHub checks: ✓
Local test suite: ✓
Approval: ✅
Local details:
[INFO] Tests run: 673, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
jordanpadams
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



🗒️ Summary
Use local file if protocol is of type file.
⚙️ Test Data and/or Report
Running against very large GEO product off line. Also, validate unit tests will need to work on PR NASA-PDS/validate# once a new jparser snapshot is released. Works locally using latest code as a precursor that it should be just fine.
♻️ Related Issues
NASA-PDS/validate#1241
🤓 Reviewer Checklist
Reviewers: Please verify the following before approving this pull request.
Security & Quality
Testing & Validation
Documentation
Maintenance