NASA-PDS/validate#1241: improved patch to use local file instead of attempting to download URL

[al-niessner]

🗒️ Summary

The validate unit tests found a small snag. Fixed.

⚙️ Test Data and/or Report

Unit testing done here should pass.

♻️ Related Issues

Part of NASA-PDS/validate#1241

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Security & Quality

• SonarCloud: Confirmed no new High or Critical security findings.
• Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
• Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

• Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
• Coverage: Automated tests cover new logic and edge cases.
• Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Documentation

• Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.

Maintenance

• Issue Traceability: The PR is linked to a valid GitHub Issue or Jira Ticket.
• Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[al-niessner]

@jordanpadams @tloubrieu-jpl @nutjob4life

Seems the local tests let a little bit pass through. Caught it in the validate unit tests however and fixed it here. Please review, merge, and deploy. Let me know when complete and I will once again apply my paranoia and test it in validate as well.

[nutjob4life]

Not sure how the code delta that changes handling of the count in dst.limit affects how a local file is used instead of a download URL, but that's part of the fun! 😉

Code delta: ✓
Tests: ✓
Approval: ✅
Maven details:

…
[INFO] Tests run: 673, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  32.939 s
…

[jordanpadams]

@al-niessner merged. should be deployed in the next 15-30 minutes