Shim dmidecode to allow for the usage of game's default encrypted auth#33
Merged
Conversation
to push against natroutter ghcr.io
Updated wrong link in the egg
|
why not use updated wings instead? |
Owner
|
Hey, thanks for the PR! The build is failing because Docker is trying to parse the shell script inside the Dockerfile as Docker instructions. The multiline shell script inside the 
|
Renamed workflow file from action to publish
Contributor
Author
|
Weird, the github builder did the trick. In any case, I one-linered it in the hopes that it does the trick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing authentication tokens in plain text is not the best of the security approach. This is a first intent to allow the usage of the default's game encryption to store the auth session internally.
I've made a small deployment of the forked egg and it is working:
Might be a good idea to check and possibly remove the authentication credentials storage for the downloader so it is not stored in plain sight either.