Fix bug in parser #723
Merged
Fix bug in parser #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K20shores
approved these changes
Feb 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
==========================================
+ Coverage 94.49% 94.50% +0.01%
==========================================
Files 63 64 +1
Lines 4376 4384 +8
==========================================
+ Hits 4135 4143 +8
Misses 241 241 ☔ View full report in Codecov by Sentry. |
sjsprecious
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the conversion of rate constant parameter units caused by underflow of an unsigned int. Updates some tutorial examples accordingly. Also, adds the option to calculate air density based on the temperature, pressure, and Ideal Gas Law.
closes #721
closes #722