-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ERF driver to NoahMP #178
Open
akashdhruv
wants to merge
36
commits into
NCAR:master
Choose a base branch
from
AIEADA:cmake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please Squash and Merge this pull request if possible. We would prefer if the history is consolidated in a single commit with the title of the PR as the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces driver for the ERF-model (https://github.com/erf-model/ERF). ERF is a C++ based application and we have developed a Fortran/C interoperability for
NoahmpIO_type
.The interoperability layer corresponds to the latest functionality available in ERF after this PR is merged:
erf-model/ERF#2196
The Fortran part of the code is largely based on the HRLDAS driver and the C interoperability layer is available in the following files:
drivers/erf/NoahmpIO.H
drivers/erf/NoahmpIO.cpp
drivers/erf/NoahmIO_fi.F90
We also provide CMake interface to build this driver. Once library is installed once can access NoahmpIO interface in C/C++ by simply including the header file
#include <NoahmpIO.H>
. See this example here:https://github.com/AIEADA/ERF/blob/13adcaf76948fcd801bde456011de97065eb5dc6/Source/LandSurfaceModel/NOAH/ERF_NOAH.H
We also introduced another header file:
drivers/erf/NoahArray.H
which casts C pointer to a Fortran style array to maintain consistency between access of array in Fortran an C++. See this example here:
https://github.com/AIEADA/ERF/blob/13adcaf76948fcd801bde456011de97065eb5dc6/Source/LandSurfaceModel/NOAH/ERF_NOAH.cpp#L203-L219