Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug that caused wrong directions from cf.DimensionCoordinate.direction #860

Merged
merged 3 commits into from
Apr 1, 2025
Merged

Fix bug that caused wrong directions from cf.DimensionCoordinate.direction #860

merged 3 commits into from
Apr 1, 2025

Conversation

davidhassell
Copy link
Collaborator

Fixes #859

@davidhassell davidhassell added the bug Something isn't working label Apr 1, 2025
sadielbartholomew
sadielbartholomew reviewed Apr 1, 2025
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have time to write a quick test for this within the next hour or so? I can forgive not having one given we are due to do a release ASAP, but ideally one can be added that would catch the original bug.

sadielbartholomew
sadielbartholomew approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job working out what was going wrong. Thanks for the quick fix and adding a test. Perfect, please merge.

@davidhassell davidhassell merged commit 76e4612 into NCAS-CMS:main Apr 1, 2025
@davidhassell davidhassell deleted the collapse-coordinate-direction branch April 1, 2025 16:00
@davidhassell davidhassell added this to the 3.17.0 milestone Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.

Error in behaviour of cf.DimensionCoordinate.direction
2 participants
@davidhassell @sadielbartholomew