Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert folder resourceType to enum #392

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

jnatten
Copy link
Contributor

@jnatten jnatten commented Feb 15, 2024

@jnatten jnatten requested a review from a team February 15, 2024 14:06
Comment on lines +49 to +55
case object Concept extends ResourceType("concept")
case object Image extends ResourceType("image")
case object Audio extends ResourceType("audio")
case object Multidisciplinary extends ResourceType("multidisciplinary")
case object Article extends ResourceType("article")
case object Learningpath extends ResourceType("learningpath")
case object Video extends ResourceType("video")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette er de jeg fant i databasen i test.
Finnes det flere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nei, dette er nok dekkende. Glose lagres som concept, og h5p kan ikkje favorittmerkes.

Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jnatten jnatten merged commit 75a625b into master Feb 20, 2024
@jnatten jnatten deleted the enum-for-resource-type branch February 20, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants