typescript: Replace scala-tsi with openapi-ts #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug with how the output type of `/audio-api/v1/audios/ids/` were generated. For some reason it is fixed when using an `Array` instead of a `List` as the output. Not sure of the reason, I assume it has to do with the recursive type of `AudioMetaInformationDTO` + `SeriesDTO`, but couldn't get it to work in a satisfying way, so lets just hack around it with `Array` for now.
Maybe we use enums for this maybe??
Since this package has remained unused, i assume it is not needed and we don't want to maintain it if that is the case 😄
This patch replaces the automatic type generation that previously relied on scala-tsi with openapi-ts (https://openapi-ts.dev/) based on automatically generated openapi types from our apis.
Since we hopefully can rely on openapi-ts and our openapi spec instead of scala-tsi, lets remove all the scala-tsi specific code.
jnatten
force-pushed
the
typescript-type-rework-simpler
branch
from
6799209 to
795d578
Compare
gunnarvelle
reviewed
Mar 20, 2025
concept-api/src/main/scala/no/ndla/conceptapi/model/api/UpdatedConceptDTO.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Har ikkje tenkt på at vi ikkje har typer for denne!
| @@ -0,0 +1,19 @@ | |||
|
|
|||
There was a problem hiding this comment.
Veldig pirk, men går det an å få vekk tom linje her?
There was a problem hiding this comment.
Det burde være mulig!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siden jeg føler vi har hatt så mye trøbbel med scalatsi så er dette et forslag på hvordan vi kan generere typer med openapi-ts ut i fra openapi spec'en vår istedenfor.
openapi-ts er ganske mye mer brukt enn scala-tsi så jeg har et lite håp om at vi skal støte på færre gotchas 😄
Lar denne stå som draft-pr frem til jeg har fikset alle typefeilene i frontend'ene siden det er potensielt ting som må endres her frem til det er i orden.
Jeg vet det ser ut som jeg har lagt til 19k linjer, men det er bare autogenerert openapi spec og typescript typer.
(openapi-ts tar med ganske mye mer data og automatisk genererer type for alle endepunktene våre).
Sånn i praksis så er det faktisk ~500 linjer færre med faktisk kode.