Add endpoints for deleting language of subject page and film front page #629
+164
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarvelle
reviewed
Mar 21, 2025
frontpage-api/src/main/scala/no/ndla/frontpageapi/controller/SubjectPageController.scala
Outdated
Show resolved
Hide resolved
frontpage-api/src/test/scala/no/ndla/frontpageapi/service/WriteServiceTest.scala
Show resolved
Hide resolved
gunnarvelle
reviewed
Mar 24, 2025
frontpage-api/src/main/scala/no/ndla/frontpageapi/controller/SubjectPageController.scala
Outdated
Show resolved
Hide resolved
amatho
force-pushed
the
delete-language-subjectpage-filmfrontpage
branch
from
a03549e to
5ab5e71
Compare
gunnarvelle
reviewed
Mar 24, 2025
There was a problem hiding this comment.
Kva skjer om du sletter siste språkversjonen som finnes? Om det skal være lov må nesten heile sida slettes. Eller så bør det kastes en exception.
There was a problem hiding this comment.
Kanskje ryddigst å kaste en exception, sånn som i draft-api?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See NDLANO/Issues#4331