Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context to get url for search. Never paths. #568

Merged
merged 5 commits into from
Mar 17, 2025

Conversation

gunnarvelle
Copy link
Member

Skal ikkje lenger bruke paths for tax.

@gunnarvelle gunnarvelle requested a review from a team March 12, 2025 12:09
@Jonas-C
Copy link
Contributor

Jonas-C commented Mar 12, 2025

Tror det er mer vi kan fjerne her! Kanskje vi til og med skal deprecate path?

Use `url` instead of `path` and `contexts` instead of `paths` for future implementations.
@Jonas-C
Copy link
Contributor

Jonas-C commented Mar 13, 2025

Hva med Movie.path? TaxonomyCrumb? TaxonomyContext? Burde vi slutte å fallbacke til path når url ikke eksisterer?

@Jonas-C
Copy link
Contributor

Jonas-C commented Mar 13, 2025

Holder fortsatt på med paths i toGQLTaxonomyContext og fire steder i programmeResolvers

@gunnarvelle gunnarvelle merged commit 73f5daa into master Mar 17, 2025
3 checks passed
@gunnarvelle gunnarvelle deleted the stop-using-paths-dammit branch March 17, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants