feat: limit hotspot height in panorama #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otacke
reviewed
Apr 28, 2024
| @@ -39,6 +39,21 @@ export default class HotspotNavButton extends React.Component { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| * React life-cycle handler: Component did update. | |||
There was a problem hiding this comment.
@henriettemoe Thanks for adopting these comments. I'd agree that they are not required, but the goal is to make it as simple for newcomers as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the height of hotspots in panorama to a static height (could be changed). And sets the max hotspot height when changing from 360 to ensure that the hotspot is not unreachable.