Skip to content

feat: add support for favoriting topics #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat: add support for favoriting topics #2241

merged 1 commit into from
Dec 11, 2024

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Nov 25, 2024 •
edited
Loading

@Jonas-C Jonas-C force-pushed the feat/favoriting-topics branch 4 times, most recently from 80195fd to b58e35d Compare December 5, 2024 09:13
@Jonas-C Jonas-C requested a review from a team December 5, 2024 09:13
@Jonas-C Jonas-C marked this pull request as ready for review December 5, 2024 09:13
gunnarvelle
gunnarvelle reviewed Dec 5, 2024
View reviewed changes
src/containers/TopicPage/TopicContainer.tsx Outdated
<AddResourceToFolderModal
resource={{
id: articleId,
path: node.path,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi kan også begynne å lagre node.url, evt sjekke på enablePrettyUrls først.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For en fremtidig migrering, er det ikke like greit å beholde alle som path inntil videre?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har ingenting å sei. Migrering med url vil berre gi 404 i tax og dermed ingen endring.

gunnarvelle
gunnarvelle approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fiks konflikter

@Jonas-C Jonas-C force-pushed the feat/favoriting-topics branch 2 times, most recently from 55c1b3c to dee0f7b Compare December 11, 2024 14:33
@Jonas-C Jonas-C force-pushed the feat/favoriting-topics branch from dee0f7b to c612020 Compare December 11, 2024 14:37
@Jonas-C Jonas-C merged commit 59c2b71 into master Dec 11, 2024
6 checks passed
@Jonas-C Jonas-C deleted the feat/favoriting-topics branch December 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarvelle gunnarvelle gunnarvelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-C @gunnarvelle