Add alertdialog and refactor form provider to wrap entirity of contentpage #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/alert-dialog-when-changing-from-dirty-step-form
…g selectedResource
MaPoKen
force-pushed
the
feature/alert-dialog-when-changing-from-dirty-step-form
branch
from
25c1870 to
404b6ee
Compare
|
Fikser du konflikter? |
…/alert-dialog-when-changing-from-dirty-step-form
|
Skal ikke dialog vises når man trykker på lukk? |
|
Burde dialog vises når man trykker neste/forrige? |
katrinewi
reviewed
Mar 17, 2025
src/containers/MyNdla/Learningpath/EditLearningpathStepsPageContent.tsx
Outdated
Show resolved
Hide resolved
src/containers/MyNdla/Learningpath/EditLearningpathStepsPageContent.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+61
to
+63
| useEffect(() => { | ||
| reset(toFormValues(stepType, step)); | ||
| }, [reset, step, stepType]); |
There was a problem hiding this comment.
Formcontexten er nå global og ikke unik for hvert steg så må vi sette formValues til dataen for steget, hver gang vi åpner et steg. Dette vet vi ikke før steget er valgt.
src/containers/MyNdla/Learningpath/EditLearningpathStepsPageContent.tsx
Outdated
Show resolved
Hide resolved
…/alert-dialog-when-changing-from-dirty-step-form
MaPoKen
force-pushed
the
feature/alert-dialog-when-changing-from-dirty-step-form
branch
from
dd97f61 to
9626fc1
Compare
…/alert-dialog-when-changing-from-dirty-step-form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fikser https://trello.com/c/jP2XMLNT/1288-neste-knappen-er-litt-for-aktiv
Alertdialogen er en ren kopi fra den vi hadde i Arena, kun fjernet knappen. Ellers har jeg skrevet om skjemaet til å være en provider rundt hele
EditLearningpathStepsPageContent, krever litt mer håndtering og omgjøring av skjemaet for de ulike stegene men virker som dette er ok.Måtte flytte provideren ut av LearningpathStepForm for å kunne kontrollere Alertdialog mellom skjema byttene. Det ble gjort for å få tilgang til Formstaten.