Spring boot again #236
Merged
Spring boot again #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnatten
reviewed
Mar 4, 2024
| @@ -43,10 +43,10 @@ public interface NodeRepository extends TaxonomyRepository<Node> { | |||
| LEFT JOIN n.parentConnections pc | |||
| WHERE ((:#{#nodeTypes == null} = true) OR n.nodeType in (:nodeTypes)) | |||
| AND (:isVisible IS NULL OR n.visible = :isVisible) | |||
| AND (:metadataFilterKey IS NULL OR jsonb_extract_path_text(n.customfields, :metadataFilterKey) IS NOT NULL) | |||
| AND (:metadataFilterKey IS NULL OR jsonb_extract_path_text(n.customfields, cast(:metadataFilterKey as text)) IS NOT NULL) | |||
There was a problem hiding this comment.
Er disse cast'ene fordi det er optionals?
There was a problem hiding this comment.
Usikker. Hibernate klaga på at det var sammenligning av tekst og object men ved å legge til cast så funka det. Samme med json_contains i linja under.
There was a problem hiding this comment.
Det skremmer meg jo litt, men så lenge det fungerer 🤷
There was a problem hiding this comment.
Feilmeldingen uten cast: function jsonb_extract_path_text(jsonb, bytea) does not exist. Så av en eller anna grunn så skjønner den ikkje at det er tekst uten at vi forteller den det, men tolker det som er byte array.
jnatten
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nyeste spring boot + bruk java 21 som runtime