Шульпин Илья. Лабораторная работа 2: LLVM. Вариант 3. #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeeMiyuki
requested review from
aobolensk,
m-ly4 and
Kuznetsov-Artyom
as code owners
m-ly4
requested changes
May 17, 2025
Comment on lines
+17
to
+18
| for (auto It = BB.begin(), End = BB.end(); It != End;) { | ||
| llvm::Instruction *I = &*It++; |
There was a problem hiding this comment.
Please use make_early_inc_range for this iterating.
| llvm::Instruction *I = &*It++; | ||
| if (auto *BI = llvm::dyn_cast<llvm::BinaryOperator>(I)) { | ||
| if (BI->getOpcode() == llvm::Instruction::Add) { | ||
| if (addFunc && addFunc->arg_size() == 2) { |
There was a problem hiding this comment.
Please check addFunc's arg_size once before all loops.
Comment on lines
+23
to
+26
| auto argIt = addFunc->arg_begin(); | ||
| llvm::Type *paramTy0 = argIt->getType(); | ||
| ++argIt; | ||
| llvm::Type *paramTy1 = argIt->getType(); |
There was a problem hiding this comment.
The same, add function arg types may be initialized before all loops. And if they are equal, one variable is enough.
aobolensk
requested changes
May 17, 2025
| ; CHECK: %result = add i32 %a, %b | ||
| ; CHECK: ret i32 %result | ||
| ; CHECK-NOT: add i32 | ||
|
|
There was a problem hiding this comment.
Please, add testing for the cases when add function is not present in LLVM IR module
aobolensk
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание будет добавленно после зеленого CI