Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hera spack-stack path #161

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

RussTreadon-NOAA
Copy link
Collaborator

The spack-stack path is changing on Hera. This PR updates the path to the new location.

Resolves #159

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jan 29, 2025
@RussTreadon-NOAA RussTreadon-NOAA changed the title update hera spack-stack path (#159) update hera spack-stack path Jan 29, 2025
@EdwardSafford-NOAA
Copy link
Collaborator

@RussTreadon-NOAA I confirmed the intel build (default) works correctly on hera with these changes. When I change build.sh to use gnu it doesn't work though. I've verified this is a pre-existing condition, not something introduced by these changes -- build in the develop branch currently fails with gnu. I didn't go very far into the weeds but at first glance I'm not sure spack-stack actually has support for gnu.

As for course of action I'm good with approving this PR, since the default condition builds correctly and I'm not sure anyone actually cares about gnu (one has to manually edit build.sh to get the gnu compiler). I can open a new issue to address the gnu build and handle that as a relatively low priority item. Thoughts?

@RussTreadon-NOAA
Copy link
Collaborator Author

@EdwardSafford-NOAA , thank you for testing this PR. I did not try the gnu build myself. It's good that you tested both feature/update_hera_path and develop. Like you, I am not aware of anyone using the gnu build.

I agree with your suggestion. A new issue can be opened to address the gnu issue. If we decide that we do not support the gnu build, we can close the issue.

@RussTreadon-NOAA
Copy link
Collaborator Author

Thank you, @EdwardSafford-NOAA. Merging now.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 1836683 into develop Jan 30, 2025
8 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/update_hera_path branch January 30, 2025 13:56
@EdwardSafford-NOAA
Copy link
Collaborator

I've added #163 to document the gnu build failure.

@RussTreadon-NOAA
Copy link
Collaborator Author

Great! Thank you @EdwardSafford-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update path to Hera spack-stack/1.6.0
2 participants