fixed warnings about unused parameter in subroutine reduce() (and pac…

…k_gp()) (#630)

* fixed warnings about unused parameters

* turned off brew update in MacOS workflow

* more parameter work

src/compack.F90

@@ -100,7 +100,7 @@ subroutine compack(fld,ndpts,idrsnum,idrstmpl,cpack,lcpack)
   integer :: igmax,nbitsgref,left,iwmax,i,ilmax,kk,ij
   integer :: ngwidthref,nbitsgwidth,nglenref,nglenlast
   integer :: maxorig,nbitorig,isd,ngroups,itemp,minpk
-  integer :: kfildo,inc,maxgrps,missopt,miss1,miss2,lg
+  integer :: inc,maxgrps,missopt,miss1,miss2,lg
   integer :: ibit,jbit,kbit,novref,lbitref,ier,ng,imax
   integer :: nbitsglen
   real(4) :: ref,rmin4
@@ -273,15 +273,14 @@ subroutine compack(fld,ndpts,idrsnum,idrstmpl,cpack,lcpack)
      else
         ! Use Dr. Glahn's algorithm for determining grouping.
         !
-        kfildo=6
         minpk=10
         inc=1
         maxgrps=((ndpts+minpk-1)/minpk)
         allocate(jmin(maxgrps))
         allocate(jmax(maxgrps))
         allocate(lbit(maxgrps))
         missopt=0
-        call pack_gp(kfildo,ifld,ndpts,missopt,minpk,inc,miss1,miss2, &
+        call pack_gp(ifld,ndpts,missopt,minpk,inc,miss1,miss2, &
              jmin,jmax,lbit,glen,maxgrps,ngroups,ibit,jbit, &
              kbit,novref,lbitref,ier)
         if(ier/=0) then
@@ -1083,14 +1082,13 @@ subroutine misspack(fld,ndpts,idrsnum,idrstmpl,cpack,lcpack)
   else
      ! Use Dr. Glahn's algorithm for determining grouping.
      !
-     kfildo=6
      minpk=10 
      inc=1
      maxgrps=(ndpts/minpk)+1
      allocate(jmin(maxgrps))
      allocate(jmax(maxgrps))
      allocate(lbit(maxgrps))
-     call pack_gp(kfildo,ifld,ndpts,missopt,minpk,inc,miss1,miss2, &
+     call pack_gp(ifld,ndpts,missopt,minpk,inc,miss1,miss2, &
           jmin,jmax,lbit,glen,maxgrps,ngroups,ibit,jbit, &
           kbit,novref,lbitref,ier)
      !print *,'SAGier = ',ier,ibit,jbit,kbit,novref,lbitref

src/pack_gp.f

@@ -51,7 +51,6 @@
 !> total bits required. If reduce() should abort, pack_gp() will be
 !> executed again without the call to reduce.
 !>
-!> @param[in] KFILDO unit number for output/print file.
 !> @param[in] IC array to hold data for packing. The values do not
 !> have to be positive at this point, but must be in the range
 !> -2**30 to +2**30 (the value of mallow). These integer values
@@ -111,7 +110,7 @@
 !> - 717 inc set = 1--non-fatal
 !>
 !> @author Harry Glahn @date 1994-02-01
-      SUBROUTINE PACK_GP(KFILDO,IC,NXY,IS523,MINPK,INC,MISSP,MISSS,
+      SUBROUTINE PACK_GP(IC,NXY,IS523,MINPK,INC,MISSP,MISSS,
      1                   JMIN,JMAX,LBIT,NOV,NDG,LX,IBIT,JBIT,KBIT,
      2                   NOVREF,LBITREF,IER)            
 
@@ -990,7 +989,7 @@ SUBROUTINE PACK_GP(KFILDO,IC,NXY,IS523,MINPK,INC,MISSP,MISSS,
 C        FOR SPACE EFFICIENCY.
 C
       IF(IRED.EQ.0)THEN
-         CALL REDUCE(KFILDO,JMIN,JMAX,LBIT,NOV,LX,NDG,IBIT,JBIT,KBIT,
+         CALL REDUCE(JMIN,JMAX,LBIT,NOV,LX,NDG,IBIT,JBIT,KBIT,
      1               NOVREF,IBXX2,IER)
 C
          IF(IER.EQ.714.OR.IER.EQ.715)THEN

src/reduce.f

@@ -14,7 +14,6 @@
 !> kbit could be determined. This furnishes a starting point for the
 !> iterations in reduce.
 !>
-!> @param[in] KFILDO unit number for output/print file.
 !> @param[inout] JMIN the minimum of each group (j=1,lx). JMIN is
 !> really the group reference and doesn't have to be the smallest
 !> value.
@@ -39,7 +38,7 @@
 !> - 715 ngp not large enough in reduce--non-fatal
 !>
 !> @author Harry Glahn @date 2001-11-01
-      SUBROUTINE REDUCE(KFILDO,JMIN,JMAX,LBIT,NOV,LX,NDG,IBIT,JBIT,KBIT,
+      SUBROUTINE REDUCE(JMIN,JMAX,LBIT,NOV,LX,NDG,IBIT,JBIT,KBIT,
      1                  NOVREF,IBXX2,IER)            
 
       CHARACTER*1 CFEED