-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to run diff resolutions for marine anl and background #3238
base: develop
Are you sure you want to change the base?
Add capability to run diff resolutions for marine anl and background #3238
Conversation
Updates to cp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the one comment
The subset of tests relevant to this PR passed. I'm marking this as ready to review. |
@@ -8,12 +8,13 @@ arguments: | |||
resdetatmos: 384 | |||
resdetocean: 0.25 | |||
nens: 0 | |||
interval: 6 | |||
interval: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refresh my memory - what does setting to 0 do to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the gdas cycle will run, not the gfs.
start: warm | ||
comroot: {{ 'RUNTESTS' | getenv }}/COMROOT | ||
expdir: {{ 'RUNTESTS' | getenv }}/EXPDIR | ||
idate: 2021063018 | ||
edate: 2021070306 | ||
#icsdir: /scratch1/NCEPDEV/climate/Jessica.Meixner/cycling/IC_2021063000_V2 | ||
icsdir: /work/noaa/da/gvernier/ensda/ictest/1440x1080x75/ | ||
#icsdir: /work/noaa/da/gvernier/ensda/ictest/1440x1080x75/ | ||
icsdir: /scratch2/NCEPDEV/ocean/Guillaume.Vernieres/data/prepics/hybrid-test/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
@@ -15,5 +15,6 @@ arguments: | |||
expdir: {{ 'RUNTESTS' | getenv }}/EXPDIR | |||
idate: 2021063018 | |||
edate: 2021070306 | |||
icsdir: /work/noaa/da/gvernier/ensda/ictest/1440x1080x75/ | |||
#icsdir: /work/noaa/da/gvernier/ensda/ictest/1440x1080x75/ | |||
icsdir: /scratch2/NCEPDEV/ocean/Guillaume.Vernieres/data/prepics/hybrid-test/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
Converting to draft until this is ready. |
It was a draft, I converted it to ready to review. If you convert it back to draft, at the very least explain why. |
Those all say to me this PR is not ready. If it is ready, those things need to be addressed. |
Fair enough. I think I made the update to the PR description. @JessicaMeixner-NOAA @CatherineThomas-NOAA and myself added the gfsv17 yaml configurations a few months ago to facilitate running experiments. These have always been pointing to user's path. I can move the offending yamls out this repo if you don't think they should be there. |
As discussed in-person before I got a chance to reply, they can stay. |
Description
This PR mostly includes configuration changes to allow the use a B-matrix at a defined resolution that may or may not be the same as the background.
Changes of note:
Addition of an interpolation step in the B-matrix job
version update for the fix files
the
gdas.cd
update is not the correct one yet.Resolves Implement the marine analysis at a resolution different from the deterministic #3230
Resolves Background error at 1/2 deg GDASApp#1375
Dependencies
Type of change
Change characteristics
How has this been tested?
Subset of the ci tests on hercules and hera
Checklist