CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos #3256

TerrenceMcGuinness-NOAA · 2025-01-24T20:02:15Z

Description

This PR extends the CTest Functional Tests:

Added output_files for C48_ATM for the validation step
Added two new JJOB Cases for C48_S2SW
- gfs_fcts_seg0
- gfs_atmos_prod_f000-f003

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? YES (updated README.md in the ctest directory)
Does this change require an update to any of the following submodules? NO

How has this been tested?

NOTE: The system is only supported on Orion where the input files are currently staged.

Also requires the user to have rocotoboot (dryrun version) the users $PATH (or in their $HOME/bin)

mterry (orion-login-2) ctests (ctests_extended) $ mkdir build

mterry (orion-login-2) ctests (ctests_extended) $ cd build

mterry (orion-login-2) build (ctests_extended) $ cmake ../.. -DICSDIR_ROOT=/work/noaa/global/glopara/data/ICSDIR -DHPC_ACCOUNT=nems -DSTAGED_TESTS_DIR=/work/noaa/stmp/GFS_CI_ROOT/ORION/STAGED_TESTS_DIR
-- gw: global-workflow baselines will be used from: '/work2/noaa/global/mterry/global-workflow_forked'
-- gw: global-workflow tests will be run at: '/work2/noaa/global/mterry/global-workflow_forked/ctests/build/ctests/RUNTESTS'
-- gw: global-workflow tests will use the allocation: 'nems'
-- gw: global-workflow tests will use ICSDIR_ROOT: '/work/noaa/global/glopara/data/ICSDIR'
-- gw: global-workflow tests will use staged data from:  '/work/noaa/stmp/GFS_CI_ROOT/ORION/STAGED_TESTS_DIR'
-- Configuring done
-- Generating done
-- Build files have been written to: /work2/noaa/global/mterry/global-workflow_forked/ctests/build

mterry (orion-login-2) build (ctests_extended) $ ctest -N
Test project /work2/noaa/global/mterry/global-workflow_forked/ctests/build
  Test  #1: test_C48_ATM_gfs_fcst_seg0_setup
  Test  #2: test_C48_ATM_gfs_fcst_seg0_stage
  Test  #3: test_C48_ATM_gfs_fcst_seg0_execute
  Test  #4: test_C48_ATM_gfs_fcst_seg0_validate
  Test  #5: test_C48_S2SW_gfs_fcst_seg0_setup
  Test  #6: test_C48_S2SW_gfs_fcst_seg0_stage
  Test  #7: test_C48_S2SW_gfs_fcst_seg0_execute
  Test  #8: test_C48_S2SW_gfs_fcst_seg0_validate
  Test  #9: test_C48_S2SW_gfs_atmos_prod_f000-f003_setup
  Test #10: test_C48_S2SW_gfs_atmos_prod_f000-f003_stage
  Test #11: test_C48_S2SW_gfs_atmos_prod_f000-f003_execute
  Test #12: test_C48_S2SW_gfs_atmos_prod_f000-f003_validate

Total Tests: 12

mterry (orion-login-2) build (ctests_extended) $ ctest -L C48_S2SW
Test project /work2/noaa/global/mterry/global-workflow_forked/ctests/build
    Start  5: test_C48_S2SW_gfs_fcst_seg0_setup
1/8 Test  #5: test_C48_S2SW_gfs_fcst_seg0_setup .................   Passed   24.41 sec
    Start  6: test_C48_S2SW_gfs_fcst_seg0_stage
2/8 Test  #6: test_C48_S2SW_gfs_fcst_seg0_stage .................   Passed    8.63 sec

Checklist

aerorahul

looks good. just a few minor comments.

ctests/scripts/validate.py

Co-authored-by: Rahul Mahajan <[email protected]>

TerrenceMcGuinness-NOAA

Commit changes from review for datetime updates in the python scripts

Co-authored-by: Rahul Mahajan <[email protected]>

…er using end=

WalterKolczynski-NOAA

Just whitespace and a small bit of documentation.

WalterKolczynski-NOAA · 2025-01-30T14:53:15Z

ctests/cases/C48_ATM_gfs_fcst_seg0.yaml

+{% set TEST_DATE_offset = TEST_DATE | add_to_datetime(H_timedelta) %}
+
+{% set cyc = TEST_DATE | strftime('%H') %}
+{% set cyc_offset = TEST_DATE_offset  | strftime('%H') %}


Suggested change

{% set cyc_offset = TEST_DATE_offset | strftime('%H') %}

{% set cyc_offset = TEST_DATE_offset | strftime('%H') %}

WalterKolczynski-NOAA · 2025-01-30T14:53:26Z

ctests/cases/C48_ATM_gfs_fcst_seg0.yaml

+{% set cyc_offset = TEST_DATE_offset  | strftime('%H') %}
+
+{% set PDY = TEST_DATE | to_YMD %}
+{% set PDY_offset = TEST_DATE_offset |  to_YMD %}


Suggested change

{% set PDY_offset = TEST_DATE_offset | to_YMD %}

{% set PDY_offset = TEST_DATE_offset | to_YMD %}

WalterKolczynski-NOAA · 2025-01-30T14:54:18Z

ctests/cases/C48_S2SW_gfs_atmos_prod_f000-f003.yaml

+{% set TEST_DATE_offset = TEST_DATE | add_to_datetime(H_timedelta) %}
+
+{% set cyc = TEST_DATE | strftime('%H') %}
+{% set cyc_offset = TEST_DATE_offset  | strftime('%H') %}


Suggested change

{% set cyc_offset = TEST_DATE_offset | strftime('%H') %}

{% set cyc_offset = TEST_DATE_offset | strftime('%H') %}

WalterKolczynski-NOAA · 2025-01-30T14:54:25Z

ctests/cases/C48_S2SW_gfs_atmos_prod_f000-f003.yaml

+{% set cyc_offset = TEST_DATE_offset  | strftime('%H') %}
+
+{% set PDY = TEST_DATE | to_YMD %}
+{% set PDY_offset = TEST_DATE_offset |  to_YMD %}


Suggested change

{% set PDY_offset = TEST_DATE_offset | to_YMD %}

{% set PDY_offset = TEST_DATE_offset | to_YMD %}

ctests/cases/C48_S2SW_gfs_fcst_seg0.yaml

ctests/scripts/validate.py

Co-authored-by: Walter Kolczynski - NOAA <[email protected]>

Terry McGUinness and others added 30 commits December 6, 2024 10:55

added ctest dir with cmake to create an experment

987ae5b

added CMakeLists for creating initial case EXPDIR usint ctest

61fcf83

ready to test getting the job names

f5f6595

move all operations of creating EXPDIR cases into configure phase

cbe3bab

got cmake configure to work for EXPDIR

6a50e14

can not do both file and variable save for execute_process

bcebeca

working cmake config up to output of job names

be7a890

Merge branch 'NOAA-EMC:develop' into ctest_jjobs_framework

2811629

loop over jobnames and create an experment for each

70a8183

update JOB name update in loop

72e5a9c

addded debug outputs

1f1fcd6

modifying plslot list to be only on a per case

ee27b02

filter pslot list for only relevent cases

bc76ddf

refining get_job_names

38838a6

modigied get_jobs_names to task and metatask names

d18ad01

got better jobname parcer working

ef0e066

Merge branch 'NOAA-EMC:develop' into ctest_jjobs_framework

519a919

replaced generate_workflows with create_experment

f813a1b

removed non-existing ENVIRONMENT setting to consolated COMMAND line

8238228

got cmake script to use creat_experiment

bf579ee

Merge branch 'NOAA-EMC:develop' into ctest_jjobs_framework

28ef1af

just getting started with addeding a ctest

374927f

add in test for configured project

8b4fc4f

added ctest and testing

ce37d86

Merge branch 'NOAA-EMC:develop' into ctest_jjobs_framework

d4e3266

moved ctests dir to top HOMEgfs/ci/ctests with its own scripts dir

bb12cda

added all jobs for tests for each case

f78181c

added data stagging dependances and started it as a stub script

46cddb7

Merge branch 'NOAA-EMC:develop' into ctest_jjobs_framework

d6c3a49

added driver for creating ctests from yaml files

434f869

TerrenceMcGuinness-NOAA self-assigned this Jan 24, 2025

TerrenceMcGuinness-NOAA requested a review from WalterKolczynski-NOAA as a code owner January 24, 2025 20:02

added Numpydoc doc strings

4abf286

TerrenceMcGuinness-NOAA changed the title ~~CTests extended - Added validation files for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos~~ CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos Jan 24, 2025

Terry McGuinness added 2 commits January 24, 2025 14:36

needed trailing lines at the end of a couple of files

9b5b032

still needed trailing line on the CMakefile

9570f8a

TerrenceMcGuinness-NOAA requested review from KateFriedman-NOAA and DavidHuber-NOAA January 24, 2025 20:38

aerorahul reviewed Jan 25, 2025

View reviewed changes

TerrenceMcGuinness-NOAA and others added 5 commits January 27, 2025 13:32

Update ctests/scripts/validate.py

1dd04fe

Co-authored-by: Rahul Mahajan <[email protected]>

Update ctests/scripts/validate.py

27e083e

Co-authored-by: Rahul Mahajan <[email protected]>

Update ctests/scripts/validate.py

f930224

Co-authored-by: Rahul Mahajan <[email protected]>

Update ctests/scripts/validate.py

3b65b38

Co-authored-by: Rahul Mahajan <[email protected]>

Merge branch 'NOAA-EMC:develop' into ctests_extended

c4c96e2

TerrenceMcGuinness-NOAA commented Jan 27, 2025

View reviewed changes

TerrenceMcGuinness-NOAA and others added 9 commits January 27, 2025 13:42

Update ctests/scripts/validate.py

b2bda5a

Co-authored-by: Rahul Mahajan <[email protected]>

Update ctests/scripts/validate.py

9bfe5e0

Co-authored-by: Rahul Mahajan <[email protected]>

Merge branch 'NOAA-EMC:develop' into ctests_extended

e58bf3b

updated staged python script to use to_datetime aswell

efd1318

made CYC cyc in yaml case files

ffb5c7e

fixed main() indentation in the stage python script

9fdd433

pynomrs space needced in stage python script before main block

c82b4b7

fixed bug introduced by suggested commit from reviewer regarding logg…

ecc2a70

…er using end=

Merge branch 'NOAA-EMC:develop' into ctests_extended

470a044

WalterKolczynski-NOAA requested changes Jan 30, 2025

View reviewed changes

TerrenceMcGuinness-NOAA and others added 3 commits January 30, 2025 15:59

Update ctests/cases/C48_S2SW_gfs_fcst_seg0.yaml

5a17753

Co-authored-by: Walter Kolczynski - NOAA <[email protected]>

Update ctests/cases/C48_S2SW_gfs_fcst_seg0.yaml

b872311

Co-authored-by: Walter Kolczynski - NOAA <[email protected]>

added doc-blocks in validate python script

7033b61

TerrenceMcGuinness-NOAA requested a review from WalterKolczynski-NOAA January 30, 2025 22:14

Merge branch 'NOAA-EMC:develop' into ctests_extended

825de73

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos #3256

CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos #3256

TerrenceMcGuinness-NOAA commented Jan 24, 2025 •

edited

Loading

aerorahul left a comment

TerrenceMcGuinness-NOAA left a comment

WalterKolczynski-NOAA left a comment

WalterKolczynski-NOAA Jan 30, 2025

WalterKolczynski-NOAA Jan 30, 2025

WalterKolczynski-NOAA Jan 30, 2025

WalterKolczynski-NOAA Jan 30, 2025

	{% set cyc_offset = TEST_DATE_offset \| strftime('%H') %}
	{% set cyc_offset = TEST_DATE_offset \| strftime('%H') %}

	{% set PDY_offset = TEST_DATE_offset \| to_YMD %}
	{% set PDY_offset = TEST_DATE_offset \| to_YMD %}

CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos #3256

Are you sure you want to change the base?

CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos #3256

Conversation

TerrenceMcGuinness-NOAA commented Jan 24, 2025 • edited Loading

Description

Change characteristics

How has this been tested?

Checklist

aerorahul left a comment

Choose a reason for hiding this comment

TerrenceMcGuinness-NOAA left a comment

Choose a reason for hiding this comment

WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

WalterKolczynski-NOAA Jan 30, 2025

Choose a reason for hiding this comment

WalterKolczynski-NOAA Jan 30, 2025

Choose a reason for hiding this comment

WalterKolczynski-NOAA Jan 30, 2025

Choose a reason for hiding this comment

WalterKolczynski-NOAA Jan 30, 2025

Choose a reason for hiding this comment

TerrenceMcGuinness-NOAA commented Jan 24, 2025 •

edited

Loading