Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating High Resolution Tests, Fixing Minor Wave Issues #3289

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

Description

This PR updates the wave fix which was unintentionally left out of PR #3190
Additionally, this updates what ICs the highres ci tests are pointing to (IC update issues: #3287 #3288)

-- Fixes #3260

Additionally, some smaller bug fixes and changes were made:

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

While the full fix for the wave IC issue does require code changes, these changes are still needed and can be included before the WW3 update is there.

How has this been tested?

  • Ran a C48 S2SW with the WW3 code update: /scratch1/NCEPDEV/climate/Jessica.Meixner/UpdateFixandHiresIC/c48t05 (Also earlier ran ci/cases/hires/C768_S2SW.yaml which ran out of time in the forecast but otherwise was succeeding: /scratch1/NCEPDEV/climate/Jessica.Meixner/UpdateFixandHiresIC/c768t01 )
  • hires/C768_S2SW.yaml on orion is in progress: /work2/noaa/marine/jmeixner/UpdateFixandHiresIC/t01c768
  • hires/C1152_S2SW.yaml on hercules is in progress: /work2/noaa/marine/jmeixner/hercules/UpdateFixandHiresIC/t01c1152

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

jobs/JGLOBAL_WAVE_POST_SBS Fixed Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants