-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating High Resolution Tests, Fixing Minor Wave Issues #3289
Open
JessicaMeixner-NOAA
wants to merge
12
commits into
NOAA-EMC:develop
Choose a base branch
from
JessicaMeixner-NOAA:fixhighrestest
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updating High Resolution Tests, Fixing Minor Wave Issues #3289
JessicaMeixner-NOAA
wants to merge
12
commits into
NOAA-EMC:develop
from
JessicaMeixner-NOAA:fixhighrestest
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix broken logic so that we do not try to copy somethign to COM
and subsequent scripts
for addressing hang issues
JessicaMeixner-NOAA
requested review from
sbanihash,
aerorahul and
WalterKolczynski-NOAA
as code owners
January 30, 2025 17:36
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the wave fix which was unintentionally left out of PR #3190
Additionally, this updates what ICs the highres ci tests are pointing to (IC update issues: #3287 #3288)
-- Fixes #3260
Additionally, some smaller bug fixes and changes were made:
-- Fixes logic issue in ush/wave_grid_interp_sbs.sh #3162
-- Fixes Add MPI environment variables for orion/hercules #3259
--- Fixes [NCO Bug] Wave post should not copy files to COM whose names might collide #297
Type of change
Change characteristics
While the full fix for the wave IC issue does require code changes, these changes are still needed and can be included before the WW3 update is there.
How has this been tested?
Checklist