Enable gcafsv1 aerosol GRIB2 processing in UPP #4147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the text file required for the GCAFS model in UFSATM. 2) Add the post_itag_gcafs file for the GCAFS model. 3) Implement and link UPP-related files for the gcafsv1 model to process aerosol GRIB2 outputs.
zhanglikate
requested review from
DavidHuber-NOAA,
TerrenceMcGuinness-NOAA,
WenMeng-NOAA and
aerorahul
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # rm -f "pgb2${grp}file_${fhr3}_${iproc}_${grid}" | ||
| file="pgb2${grp}file_${fhr3}_${iproc}_${grid}" | ||
| # only concatenate if file exists and is non-empty | ||
| if [[ -s "$file" ]]; then |
Check notice
Code scanning / shellcheck
Prefer putting braces around variable references even when not strictly required. Note
| file="pgb2${grp}file_${fhr3}_${iproc}_${grid}" | ||
| # only concatenate if file exists and is non-empty | ||
| if [[ -s "$file" ]]; then | ||
| cat "$file" >> "pgb2${grp}file_${fhr3}_${grid}" |
Check notice
Code scanning / shellcheck
Prefer putting braces around variable references even when not strictly required. Note
| if [[ -s "$file" ]]; then | ||
| cat "$file" >> "pgb2${grp}file_${fhr3}_${grid}" | ||
| fi | ||
| rm -f -- "$file" |
Check notice
Code scanning / shellcheck
Prefer putting braces around variable references even when not strictly required. Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the UPP system to support aerosol GRIB2 output for the gcafsv1 model within UFSATM.
Specifically:
Updates UPP to the develop branch to include the text file required for the GCAFS model in UFSATM.
Adds the post_itag_gcafs file for the GCAFS model.
Implements and links UPP-related components for the gcafsv1 model to process aerosol GRIB2 outputs.
These changes enhance UFSATM’s capability to handle aerosol fields generated by GCAFS for post-processing and analysis.
Type of change
Change characteristics
How has this been tested?
Checklist