-
Notifications
You must be signed in to change notification settings - Fork 203
Create a UPP module for the global workflow #4174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
I verified that all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A question and a suggestion.
Co-authored-by: Rahul Mahajan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @DavidHuber-NOAA
modulefiles/gw_upp.wcoss2.lua
Outdated
| load("wcoss2_intel") | ||
|
|
||
| load(pathJoin("cray-pals", "1.0.17")) | ||
| load(pathJoin("cfp", "2.0.4")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think cfp module is not needed in off-line post. It is only used in atmos_product.sh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I will remove this and rerun the upp jobs from the last cycle of the C96_atm3DVar_extended test to verify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All UPP jobs ran successfully.
Description
This adds a global workflow module for
uppjobs running on WCOSS2. This will ensure that the samecrtmmodule (and other modules) used to build the UPP are loaded at runtime.Resolves #4125
Type of change
Change characteristics
How has this been tested?
Full testing suite on WCOS2/Cactus. Extended tests are still running, but have completed the first full cycle.
Checklist