Skip to content

Conversation

@DavidHuber-NOAA
Copy link
Contributor

Description

This adds a global workflow module for upp jobs running on WCOSS2. This will ensure that the same crtm module (and other modules) used to build the UPP are loaded at runtime.

Resolves #4125

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Full testing suite on WCOS2/Cactus. Extended tests are still running, but have completed the first full cycle.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners

@DavidHuber-NOAA DavidHuber-NOAA changed the title Fix/upp mods Create a UPP module for the global workflow Oct 24, 2025
@DavidHuber-NOAA
Copy link
Contributor Author

I verified that all C96_atm3DVar_extended GRIB2 products in COM are bitwise identical between this branch and develop through the 2nd full cycle (2021122100 through 2021122112) including GOES simulated imagery.

aerorahul
aerorahul previously approved these changes Oct 24, 2025
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A question and a suggestion.

aerorahul
aerorahul previously approved these changes Oct 24, 2025
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @DavidHuber-NOAA

load("wcoss2_intel")

load(pathJoin("cray-pals", "1.0.17"))
load(pathJoin("cfp", "2.0.4"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cfp module is not needed in off-line post. It is only used in atmos_product.sh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will remove this and rerun the upp jobs from the last cycle of the C96_atm3DVar_extended test to verify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All UPP jobs ran successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the module loading from dev/jobs/upp.sh to a new gw_upp.wcoss2.lua

3 participants