Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picks up latest UPP with an important fix for smoke and dust #633

Merged

Conversation

MatthewPyle-NOAA
Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA commented Feb 12, 2025

DESCRIPTION OF CHANGES:

  • Simply updates the hash of UPP to the latest (12/2/2024) commit for the rrfsv1 release branch that fixed two issues with how smoke and dust output was labeled in GRIB output.
  • Also updates needed UPP fix files to properly label total_aerosol for the time-averaged product.

TESTS CONDUCTED:

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others: Just pulled and compiled the code, and confirmed that it had grabbed the required version of UPP.

ISSUE:

CONTRIBUTORS (optional):

@EricJames-NOAA made the UPP fix, and Partha let me know about it when I asked him about what I was seeing in S&D output.

@MatthewPyle-NOAA MatthewPyle-NOAA marked this pull request as ready for review February 12, 2025 12:52
@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 41a064b into NOAA-EMC:main Feb 12, 2025
2 checks passed
@MatthewPyle-NOAA MatthewPyle-NOAA deleted the feature/updateupphash branch February 12, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants